ref(auth): read public keys from files on init #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
force-pushed
the
matt/auth-key-files
branch
from
e51708a to
ef2a824
Compare
jan-auer
approved these changes
Dec 17, 2025
matt-codecov
added a commit
that referenced
this pull request
Dec 18, 2025
depends on: - #240 - #237 - #243 rust and python e2e tests now have authorization checks enabled. i added new test cases to ensure requests fail when the token has the wrong scope or wrong permissions, but currently the server throws 500 for any issue so the tests can't actually assert 403 like they should i am told the `.secret_scan_ignore` file should prevent our scanners from yelling about the checked-in test keys. the format with escaped slashes is strange but that's what was on the doc i was sent ¯\_(ツ)_/¯ Ref FS-202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we will mount k8s secrets as files. our config schema must therefore be updated to take key files rather than key material.
additionally, a
PublicKeyDirectorystruct is now created on service initialization which pre-reads the key files and pre-parses them intoDecodingKeys.related to https://github.com/getsentry/ops/pull/18477
Ref FS-160
Ref FS-161