Add tokenizers package
#1675
Merged
Add tokenizers package
#1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tokenizers` is used for tokenization of strings. While we do currently import titoken as well, we want to use `tokenizers` to count tokens the same way Seer does in Sentry for stacktrace token counts. We could consider converting usages of titoken to `tokenizers` to maintain a dependency on only one tokenization package, but for now we will have them both.
kddubey
approved these changes
Sep 29, 2025
JoshFerge
reviewed
Sep 29, 2025
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
i would prefer if we could vendor the library -- otherwise we should audit these other dependencies it's adding
JoshFerge
approved these changes
Sep 29, 2025
joshuarli
approved these changes
Sep 29, 2025
Member
joshuarli
left a comment
joshuarli
left a comment
There was a problem hiding this comment.
most of the extra stuff is from huggingface-hub: https://github.com/huggingface/huggingface_hub/blob/main/setup.py#L14
shrug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenizersis used for tokenization of strings. While we do currently import titoken as well, we want to usetokenizersto count tokens the same way Seer does in Sentry for stacktrace token counts. We could consider converting usages of titoken totokenizersto maintain a dependency on only one tokenization package, but for now we will have them both.