Skip to content

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jan 28, 2025

Draft until we decide if this is the right approach. (In other words, ignore the questions I asked below for now.)


As part of a larger bug fix, we are in the midst of trying to move in_app logic from the Python SDK to the sentry server. To do that, we need to send the app's root path in the event, which we are for now planning to include in debug_meta.

In my testing, I discovered that even though the debug_meta schema includes an other entry with the note /// Additional arbitrary fields for forwards compatibility, in order for the project root data to make it all the way to the grouping algorithm it has to survive the normalizer, and to do that, it has to be an explicitly listed. (Reviewers, please correct me if I'm wrong about this.) This PR does that, and adds a note explaining the requirement for any future additions.

Note to reviewers: I got the metastructure values from the abs_path entry, to which the project_root will get compared. Happy to change any of them if needed. I also didn't add or modify any tests related to this change. If that's needed, I would appreciate some guidance as I've never worked in rust before.

@Dav1dde
Copy link
Member

Dav1dde commented May 20, 2025

@lobsterkatie closing this for now, please just re-open if you still need it/work on it. Just going through open PRs and trying to catch up on stuff we may have missed or is stale.

@Dav1dde Dav1dde closed this May 20, 2025
@Dav1dde Dav1dde deleted the kmclb-add-project-root-to-debug-meta branch June 20, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants