feat(processor): Add Span Attachment scrubbing logic #5449
+497
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
commented
Dec 5, 2025
Comment on lines
+292
to
+298
| // FIXME: Not a fan of this at all, the fact that the UI is misleading around this does not help IMO. | ||
| // Also also kind of weird since you can add a bogus rule to get around this (or even add a rule by accident to get around this). | ||
| // From attachments.rs: | ||
| // We temporarily only scrub attachments to projects that have at least one simple attachment rule, | ||
| // such as `$attachments.'foo.txt'`. | ||
| // After we have assessed the impact on performance we can relax this condition. | ||
| && utils::attachments::has_simple_attachment_selector(config) |
Member
Author
There was a problem hiding this comment.
For me this is actually very confusing and ideally I would like to change it if we can.
Member
There was a problem hiding this comment.
Feel free to remove the extra check for span attachments, they will start out as low-volume anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the logic to scrub the attachment body as well as the attachment meta.