fix #751: add package_data#752
Merged
markstory merged 3 commits intogetsentry:masterfrom Jan 13, 2025
Merged
Conversation
markstory
reviewed
Jan 13, 2025
markstory
reviewed
Jan 13, 2025
Member
|
Thank you 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #751
In the PR the
include_package_dataflag was removed fromsetup.py.This caused the
py.typedmarker file to also be removed, resulting in mypy errors:Using
package_datawe can pick specific files instead of everything (which was the motive for the latest change).