Skip to content

feat: healthchecks for sentry components #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 13, 2025
Merged

feat: healthchecks for sentry components #3859

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2c50ba5
feat: add snuba healthcheck
mzglinski Aug 7, 2025
4ccd82f
fix: snuba healthchecks
mzglinski Aug 7, 2025
ecb3757
fix: remove healthcheck from replacer
mzglinski Aug 7, 2025
cbb71fa
feat: add healthchecks to sentry
mzglinski Aug 7, 2025
ed2efbb
fix: small changes to sentry healthchecks
mzglinski Aug 7, 2025
32ad250
fix: worker healthcheck
mzglinski Aug 7, 2025
7e9edcb
feat: vroom healthcheck
mzglinski Aug 7, 2025
828bb35
feat: symbolicator healthcheck
mzglinski Aug 7, 2025
e1a400a
feat: add nginx healthcheck
mzglinski Aug 7, 2025
6bed0eb
fix: typo in .env
mzglinski Aug 7, 2025
80fa06f
fix: typo in docker-compose.yml
mzglinski Aug 7, 2025
fc43389
test: increase docker compose --wait-timeout
mzglinski Aug 7, 2025
dcb496d
Revert "test: increase docker compose --wait-timeout"
mzglinski Aug 7, 2025
14eff39
fix: do not use healthcheck: [disabled: true], since it breaks docker…
mzglinski Aug 7, 2025
2409027
Merge branch 'master' into feat/healthchecks
aldy505 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ UPTIME_CHECKER_IMAGE=ghcr.io/getsentry/uptime-checker:nightly
HEALTHCHECK_INTERVAL=30s
HEALTHCHECK_TIMEOUT=1m30s
HEALTHCHECK_RETRIES=10
HEATLHCHECK_START_PERIOD=10s
HEALTHCHECK_FILE_INTERVAL=60s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: A typo in the `HEATLHCHECK_START_PERIOD` variable name causes the healthcheck grace period to be ignored, potentially leading to premature service restarts.
  • Description: A typo in the environment variable HEATLHCHECK_START_PERIOD (missing an 'H') in the .env file and its reference in docker-compose.yml will cause Docker Compose to substitute an empty string for the healthcheck start_period. This leads to the value defaulting to 0s instead of the intended 10s. As a result, multiple services including postgres, redis, kafka, and web will not have the intended grace period during startup, which could cause them to be marked as unhealthy and restart unnecessarily, impacting system reliability.
  • Suggested fix: Correct the typo in the environment variable name from HEATLHCHECK_START_PERIOD to HEALTHCHECK_START_PERIOD in the .env file and update the corresponding reference in docker-compose.yml.
    severity: 0.65, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

HEALTHCHECK_FILE_TIMEOUT=10s
HEALTHCHECK_FILE_RETRIES=1
HEALTHCHECK_FILE_START_PERIOD=180s
# Caution: Raising max connections of postgres increases CPU and RAM usage
# see https://github.com/getsentry/self-hosted/pull/2740 for more information
POSTGRES_MAX_CONNECTIONS=100
Expand Down
Loading
Loading