Skip to content

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Aug 14, 2025

Using matrix.os only works on self-hosted. SH e2e test on other repositories would still fail.

Refer to https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#runner-context

Follow up to #3874

Using matrix.os only works on self-hosted. SH e2e test on other repositories would still fail.

Refer to https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#runner-context
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, does sentry gets tested on x86?

@aldy505
Copy link
Collaborator Author

aldy505 commented Aug 14, 2025

Out of curiosity, does sentry gets tested on x86?

No, but just in case.

I'm okay with removing it.

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking x86 is not a blocker IMO anyway.

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (0f606d2) to head (9dc83c2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3876   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 merged commit 3614389 into master Aug 14, 2025
12 of 13 checks passed
@aldy505 aldy505 deleted the aldy505/fix/action-assert-runner branch August 14, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants