fix: ensure seaweedfs lifecycle policy is set correctly #4040
Conversation
| echo "Node store already exists, skipping creation..." | ||
| fi | ||
|
|
||
| if [[ -z "${APPLY_AUTOMATIC_CONFIG_UPDATES:-}" || "$APPLY_AUTOMATIC_CONFIG_UPDATES" == 1 ]]; then |
There was a problem hiding this comment.
I added this if for users who manually changed their lifecycle policy, but this should probably be a separate CLI option or environment variable.
Ideally, we would check the existing policy matches what we expect or explicitly just update the <Days> part in our <Rule>. But that would require parsing XML and I don't think there is currently a setup to do this
There was a problem hiding this comment.
Ideally, we would check the existing policy matches what we expect or explicitly just update the
<Days>part in our<Rule>. But that would require parsing XML and I don't think there is currently a setup to do this
Yeah I don't think that's possible
There was a problem hiding this comment.
There's this tool: https://github.com/TomWright/dasel
|
why did I approve it again... |
3 participants
Fixes #4028
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.