Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 2, 2025

This PR will adds the missing integrations inboundFiltersIntegration, functionToStringIntegration, browserApiErrorsIntegration, breadcrumbsIntegration, globalHandlersIntegration, linkedErrorsIntegration, dedupeIntegration and browserSessionIntegration
fixing the parameters ignoreErrors, ignoreTransactions, allowUrls, denyUrls that weren't working previously.

It will also fix the breadcrumbs that weren't showing, and also fixing the old issue that doesn't add native breadcrumbs to it.

Fixes #263

…tion, browserApiErrorsIntegration, breadcrumbsIntegration, globalHandlerIntegrations, globalHandlersIntegration, linkedErrorsIntegration, dedupeIntegration. / fixed device context integration not loading. / implemented breadcrumbs merge from android to JS. / Breadcrumbs are now tied to events
@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 4, 2025 12:52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding it that this is the same code as RNSentryMapConverter. Correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, with only minor changes since we don't depend on React Native imports.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments but overall LGTM 🚀

return;
}
final Map<String, Object> serialized =
InternalSentrySdk.serializeScope(context, (SentryAndroidOptions) options, currentScope);

This comment was marked as outdated.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@lucas-zimerman lucas-zimerman merged commit 605be43 into V3 Dec 4, 2025
12 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/v3/integrations2 branch December 4, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants