-
-
Notifications
You must be signed in to change notification settings - Fork 38
Ref(V3): Add missing integrations / fix breadcrumbs and device context #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion, browserApiErrorsIntegration, breadcrumbsIntegration, globalHandlerIntegrations, globalHandlersIntegration, linkedErrorsIntegration, dedupeIntegration. / fixed device context integration not loading. / implemented breadcrumbs merge from android to JS. / Breadcrumbs are now tied to events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding it that this is the same code as RNSentryMapConverter. Correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, with only minor changes since we don't depend on React Native imports.
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments but overall LGTM 🚀
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
This PR will adds the missing integrations
inboundFiltersIntegration,functionToStringIntegration,browserApiErrorsIntegration,breadcrumbsIntegration,globalHandlersIntegration,linkedErrorsIntegration,dedupeIntegrationandbrowserSessionIntegrationfixing the parameters
ignoreErrors,ignoreTransactions,allowUrls,denyUrlsthat weren't working previously.It will also fix the breadcrumbs that weren't showing, and also fixing the old issue that doesn't add native breadcrumbs to it.
Fixes #263