Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

Description

The --ignore option for sourcemaps upload and sourcemaps inject commands now interprets patterns relative to the current working directory (CWD) for more intuitive behavior. Previously, patterns were matched relative to each individual search path.

This change was implemented by switching from ignore::overrides::OverrideBuilder to WalkBuilder::filter_entry with glob::Pattern for pattern matching. The help text for the --ignore option has been updated to reflect this new behavior. New integration tests have been added to verify the CWD-relative ignore functionality.

This is a v3.0 breaking change; users relying on the old behavior will need to update their ignore patterns.

Issues

No specific issue ID was provided for this task.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Nov 24, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Fix intuitive path behavior for sourcemaps ([#2979](https://github.com/getsentry/sentry-cli/pull/2979))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 6708598

This change updates the ignore pattern matching logic to correctly handle patterns relative to the current working directory. It also adds new integration tests to verify this behavior for both `sourcemaps inject` and `sourcemaps upload` commands.

Co-authored-by: daniel.szoke <[email protected]>
@szokeasaurusrex szokeasaurusrex force-pushed the cursor/fix-intuitive-path-behavior-for-sourcemaps-claude-4.5-sonnet-thinking-2872 branch from b519afd to 1411b8c Compare November 24, 2025 15:50
@szokeasaurusrex szokeasaurusrex changed the base branch from master to szokeasaurusrex/remove-brotli November 24, 2025 15:51
@szokeasaurusrex
Copy link
Member Author

I think we will want to go with a different approach: using walkdir instead of ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants