Draft
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add snapshots subcommand ([#3049](https://github.com/getsentry/sentry-cli/pull/3049))If none of the above apply, you can opt out of this check by adding |
lcian
added a commit
that referenced
this pull request
Feb 27, 2026
Updated version of #3049 to discuss and iterate on things. Notable changes: - Removed `shard_index` parameter from the command. I'm not sure what the purpose of that was originally. - This uses the new `many` (batch) API from `objectstore_client`. All uploads are executed as batch requests, reducing network overhead. Unfortunately, with they way things are implemented now, we will still have to buffer all files in memory before sending the request, as we need to hash their contents to determine the filename. If we could just use the filename as the key in objectstore, it would be much better because that way we could stream the files over. Note that the objectstore endpoint is currently gated by a feature flag, and only enabled for internal orgs/teams. Ref FS-233 --------- Co-authored-by: Noah Martin <noahm444@gmail.com> Co-authored-by: Ryan Brooks <ryanjeffrey.brooks112@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just sharing this early version of a snapshot upload command to collaborate on it. A lot is still TBD such as objectstore public endpoints and connection pooling