Skip to content

ci: Remove DangerJS from CI workflow #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szokeasaurusrex wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −15
Open

ci: Remove DangerJS from CI workflow #3074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,31 +37,18 @@ jobs:
name: Test Swift
uses: ./.github/workflows/swift-test.yml

danger:
name: Run Danger Checks
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: write
statuses: write
if: ${{ github.event_name == 'pull_request' }}
steps:
- name: Run Danger
uses: getsentry/github-workflows/danger@13be9bec4ec5cd67061b747972b996e9c80f4f3b # 3.1.0

required:
name: Check required jobs
runs-on: ubuntu-24.04
needs: [lint, test, test_node, test_swift, danger]
needs: [lint, test, test_node, test_swift]
if: always()
steps:
- name: Check for failure
if: ${{
needs.lint.result != 'success' ||
needs.test.result != 'success' ||
needs.test_node.result != 'success' ||
needs.test_swift.result != 'success' ||
(needs.danger.result != 'success' && needs.danger.result != 'skipped')
needs.test_swift.result != 'success'
}}
run: |
echo "One or more jobs failed"
Expand Down