Skip to content

Commit e1e5f3b

Browse files
authored
ref: Renames SentrySpan class to SentrySpanInternal (#7172)
* ref: Renames `SentrySpan` class to `SentrySpanInternal` * ref: Update test to use `SentrySpanInternal` instead of `SentrySpan` * Rename SentrySpan files * Fix imports
1 parent ffe0649 commit e1e5f3b

34 files changed

+114
-108
lines changed

Sentry.xcodeproj/project.pbxproj

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@
604604
84A305572BC9EF8C00D84283 /* SentryTraceProfiler.h in Headers */ = {isa = PBXBuildFile; fileRef = 84A305552BC9EF8C00D84283 /* SentryTraceProfiler.h */; };
605605
84A305582BC9EF8C00D84283 /* SentryTraceProfiler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 84A305562BC9EF8C00D84283 /* SentryTraceProfiler.mm */; };
606606
84A5D75B29D5170700388BFA /* TimeInterval+Sentry.swift in Sources */ = {isa = PBXBuildFile; fileRef = 84A5D75A29D5170700388BFA /* TimeInterval+Sentry.swift */; };
607-
84A7890A2C0E9F6400FF0803 /* SentrySpan+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 84A789092C0E9F5800FF0803 /* SentrySpan+Private.h */; };
607+
84A7890A2C0E9F6400FF0803 /* SentrySpanInternal+Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 84A789092C0E9F5800FF0803 /* SentrySpanInternal+Private.h */; };
608608
84A8891C28DBD28900C51DFD /* SentryDevice.h in Headers */ = {isa = PBXBuildFile; fileRef = 84A8891A28DBD28900C51DFD /* SentryDevice.h */; };
609609
84A8891D28DBD28900C51DFD /* SentryDevice.m in Sources */ = {isa = PBXBuildFile; fileRef = 84A8891B28DBD28900C51DFD /* SentryDevice.m */; };
610610
84A8892128DBD8D600C51DFD /* SentryDeviceTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 84A8892028DBD8D600C51DFD /* SentryDeviceTests.m */; };
@@ -648,7 +648,7 @@
648648
8E133FA625E72EB400ABD0BF /* SentrySamplingContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E133FA525E72EB400ABD0BF /* SentrySamplingContext.h */; settings = {ATTRIBUTES = (Public, ); }; };
649649
8E4A037825F6F52100000D77 /* SentrySampleDecision.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4A037725F6F52100000D77 /* SentrySampleDecision.h */; settings = {ATTRIBUTES = (Public, ); }; };
650650
8E4E7C6D25DAAAFE006AB9E2 /* SentryTransaction.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4E7C6B25DAAAFE006AB9E2 /* SentryTransaction.h */; };
651-
8E4E7C6E25DAAAFE006AB9E2 /* SentrySpan.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4E7C6C25DAAAFE006AB9E2 /* SentrySpan.h */; };
651+
8E4E7C6E25DAAAFE006AB9E2 /* SentrySpanInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4E7C6C25DAAAFE006AB9E2 /* SentrySpanInternal.h */; };
652652
8E4E7C7425DAAB49006AB9E2 /* SentrySpanProtocol.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4E7C7325DAAB49006AB9E2 /* SentrySpanProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
653653
8E4E7C7D25DAB287006AB9E2 /* SentryTracer.h in Headers */ = {isa = PBXBuildFile; fileRef = 8E4E7C7B25DAB287006AB9E2 /* SentryTracer.h */; };
654654
8E4E7C8225DAB2A5006AB9E2 /* SentryTracer.m in Sources */ = {isa = PBXBuildFile; fileRef = 8E4E7C8125DAB2A5006AB9E2 /* SentryTracer.m */; };
@@ -671,7 +671,7 @@
671671
8EAE980B261E9F530073B6B3 /* SentryPerformanceTracker.h in Headers */ = {isa = PBXBuildFile; fileRef = 8EAE9809261E9F530073B6B3 /* SentryPerformanceTracker.h */; };
672672
8EAE980C261E9F530073B6B3 /* SentryDefaultUIViewControllerPerformanceTracker.h in Headers */ = {isa = PBXBuildFile; fileRef = 8EAE980A261E9F530073B6B3 /* SentryDefaultUIViewControllerPerformanceTracker.h */; };
673673
8EBF870926140D37001A6853 /* SentryPerformanceTracker.m in Sources */ = {isa = PBXBuildFile; fileRef = 8EBF870726140D37001A6853 /* SentryPerformanceTracker.m */; };
674-
8EC3AE7A25CA23B600E7591A /* SentrySpan.m in Sources */ = {isa = PBXBuildFile; fileRef = 8EC3AE7925CA23B600E7591A /* SentrySpan.m */; };
674+
8EC3AE7A25CA23B600E7591A /* SentrySpanInternal.m in Sources */ = {isa = PBXBuildFile; fileRef = 8EC3AE7925CA23B600E7591A /* SentrySpanInternal.m */; };
675675
8EC4CF4A25C38DAA0093DEE9 /* SentrySpanStatus.h in Headers */ = {isa = PBXBuildFile; fileRef = 8EC4CF4725C38CAF0093DEE9 /* SentrySpanStatus.h */; settings = {ATTRIBUTES = (Public, ); }; };
676676
8EC4CF5025C3A0070093DEE9 /* SentrySpanContextTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8EC4CF4F25C3A0070093DEE9 /* SentrySpanContextTests.swift */; };
677677
8ECC673D25C23996000E2BF6 /* SentrySpanId.h in Headers */ = {isa = PBXBuildFile; fileRef = 8ECC673825C23995000E2BF6 /* SentrySpanId.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -1996,7 +1996,7 @@
19961996
84A305562BC9EF8C00D84283 /* SentryTraceProfiler.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = SentryTraceProfiler.mm; sourceTree = "<group>"; };
19971997
84A305592BC9FD1600D84283 /* SentryTraceProfiler+Test.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "SentryTraceProfiler+Test.h"; sourceTree = "<group>"; };
19981998
84A5D75A29D5170700388BFA /* TimeInterval+Sentry.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "TimeInterval+Sentry.swift"; sourceTree = "<group>"; };
1999-
84A789092C0E9F5800FF0803 /* SentrySpan+Private.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = "SentrySpan+Private.h"; path = "include/SentrySpan+Private.h"; sourceTree = "<group>"; };
1999+
84A789092C0E9F5800FF0803 /* SentrySpanInternal+Private.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = "SentrySpanInternal+Private.h"; path = "include/SentrySpanInternal+Private.h"; sourceTree = "<group>"; };
20002000
84A8891A28DBD28900C51DFD /* SentryDevice.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentryDevice.h; path = include/SentryDevice.h; sourceTree = "<group>"; };
20012001
84A8891B28DBD28900C51DFD /* SentryDevice.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentryDevice.m; sourceTree = "<group>"; };
20022002
84A8892028DBD8D600C51DFD /* SentryDeviceTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentryDeviceTests.m; sourceTree = "<group>"; };
@@ -2039,7 +2039,7 @@
20392039
8E4A038325F76A7600000D77 /* TypeMapping.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TypeMapping.swift; sourceTree = "<group>"; };
20402040
8E4A038425F76A7600000D77 /* Invocation.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Invocation.swift; sourceTree = "<group>"; };
20412041
8E4E7C6B25DAAAFE006AB9E2 /* SentryTransaction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentryTransaction.h; path = include/SentryTransaction.h; sourceTree = "<group>"; };
2042-
8E4E7C6C25DAAAFE006AB9E2 /* SentrySpan.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentrySpan.h; path = include/SentrySpan.h; sourceTree = "<group>"; };
2042+
8E4E7C6C25DAAAFE006AB9E2 /* SentrySpanInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentrySpanInternal.h; path = include/SentrySpanInternal.h; sourceTree = "<group>"; };
20432043
8E4E7C7325DAAB49006AB9E2 /* SentrySpanProtocol.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentrySpanProtocol.h; path = Public/SentrySpanProtocol.h; sourceTree = "<group>"; };
20442044
8E4E7C7B25DAB287006AB9E2 /* SentryTracer.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentryTracer.h; path = include/SentryTracer.h; sourceTree = "<group>"; };
20452045
8E4E7C8125DAB2A5006AB9E2 /* SentryTracer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SentryTracer.m; sourceTree = "<group>"; };
@@ -2065,7 +2065,7 @@
20652065
8EAE9809261E9F530073B6B3 /* SentryPerformanceTracker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentryPerformanceTracker.h; path = include/SentryPerformanceTracker.h; sourceTree = "<group>"; };
20662066
8EAE980A261E9F530073B6B3 /* SentryDefaultUIViewControllerPerformanceTracker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentryDefaultUIViewControllerPerformanceTracker.h; path = include/SentryDefaultUIViewControllerPerformanceTracker.h; sourceTree = "<group>"; };
20672067
8EBF870726140D37001A6853 /* SentryPerformanceTracker.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentryPerformanceTracker.m; sourceTree = "<group>"; };
2068-
8EC3AE7925CA23B600E7591A /* SentrySpan.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentrySpan.m; sourceTree = "<group>"; };
2068+
8EC3AE7925CA23B600E7591A /* SentrySpanInternal.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentrySpanInternal.m; sourceTree = "<group>"; };
20692069
8EC4CF4725C38CAF0093DEE9 /* SentrySpanStatus.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentrySpanStatus.h; path = Public/SentrySpanStatus.h; sourceTree = "<group>"; };
20702070
8EC4CF4F25C3A0070093DEE9 /* SentrySpanContextTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentrySpanContextTests.swift; sourceTree = "<group>"; };
20712071
8ECC673825C23995000E2BF6 /* SentrySpanId.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentrySpanId.h; path = Public/SentrySpanId.h; sourceTree = "<group>"; };
@@ -4211,9 +4211,9 @@
42114211
8E8C57A025EEFC07001CEEFA /* SentrySampling.m */,
42124212
8E133FA525E72EB400ABD0BF /* SentrySamplingContext.h */,
42134213
8E133FA025E72DEF00ABD0BF /* SentrySamplingContext.m */,
4214-
8E4E7C6C25DAAAFE006AB9E2 /* SentrySpan.h */,
4215-
8EC3AE7925CA23B600E7591A /* SentrySpan.m */,
4216-
84A789092C0E9F5800FF0803 /* SentrySpan+Private.h */,
4214+
8E4E7C6C25DAAAFE006AB9E2 /* SentrySpanInternal.h */,
4215+
8EC3AE7925CA23B600E7591A /* SentrySpanInternal.m */,
4216+
84A789092C0E9F5800FF0803 /* SentrySpanInternal+Private.h */,
42174217
8ECC673925C23996000E2BF6 /* SentrySpanContext.h */,
42184218
8ECC674325C23A1F000E2BF6 /* SentrySpanContext.m */,
42194219
622C08D929E554B9002571D4 /* SentrySpanContext+Private.h */,
@@ -5332,7 +5332,7 @@
53325332
0A9E917128DC7E7000FB4182 /* SentryInternalCDefines.h in Headers */,
53335333
63FE711F20DA4C1000CDBAE8 /* SentryCrashObjC.h in Headers */,
53345334
7BC3936825B1AB3E004F03D3 /* SentryLevelMapper.h in Headers */,
5335-
8E4E7C6E25DAAAFE006AB9E2 /* SentrySpan.h in Headers */,
5335+
8E4E7C6E25DAAAFE006AB9E2 /* SentrySpanInternal.h in Headers */,
53365336
84DEE8762B69AD6400A7BC17 /* SentryLaunchProfiling.h in Headers */,
53375337
D8ACE3CE2762187D00F5A213 /* SentryFileIOTrackerHelper.h in Headers */,
53385338
03F84D2427DD414C008FE43F /* SentryCompiler.h in Headers */,
@@ -5466,7 +5466,7 @@
54665466
D8A3649D2C91AA3300AC569B /* SentryReplayApi.h in Headers */,
54675467
63AA769D1EB9C57A00D153DE /* SentryError.h in Headers */,
54685468
63FE714F20DA4C1100CDBAE8 /* SentryCrashNSErrorUtil.h in Headers */,
5469-
84A7890A2C0E9F6400FF0803 /* SentrySpan+Private.h in Headers */,
5469+
84A7890A2C0E9F6400FF0803 /* SentrySpanInternal+Private.h in Headers */,
54705470
7BC5B6FA290BCDE500D99477 /* SentryHttpStatusCodeRange+Private.h in Headers */,
54715471
9286059529A5096600F96038 /* SentryGeo.h in Headers */,
54725472
8E4E7C7D25DAB287006AB9E2 /* SentryTracer.h in Headers */,
@@ -6031,7 +6031,7 @@
60316031
848A45192BBF8D33006AAAEC /* SentryContinuousProfiler.mm in Sources */,
60326032
D81988C32BEC189C0020E36C /* SentryRRWebMetaEvent.swift in Sources */,
60336033
F458D1192E186E000028273E /* SentryScopePersistentStore+Extras.swift in Sources */,
6034-
8EC3AE7A25CA23B600E7591A /* SentrySpan.m in Sources */,
6034+
8EC3AE7A25CA23B600E7591A /* SentrySpanInternal.m in Sources */,
60356035
6360850E1ED2AFE100E8599E /* SentryBreadcrumb.m in Sources */,
60366036
D82859432C3E753C009A28AA /* SentrySessionReplaySyncC.c in Sources */,
60376037
D833D57C2D10784800961E7A /* SentryRRWebOptionsEvent.swift in Sources */,

Sources/Sentry/SentryBuildAppStartSpans.m

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
#import "SentryAppStartMeasurement.h"
2-
#import "SentrySpan.h"
32
#import "SentrySpanContext+Private.h"
43
#import "SentrySpanId.h"
4+
#import "SentrySpanInternal.h"
55
#import "SentrySwift.h"
66
#import "SentryTraceOrigin.h"
77
#import "SentryTracer.h"
88
#import <SentryBuildAppStartSpans.h>
99

1010
#if SENTRY_HAS_UIKIT
1111

12-
SentrySpan *
12+
SentrySpanInternal *
1313
sentryBuildAppStartSpan(
1414
SentryTracer *tracer, SentrySpanId *parentId, NSString *operation, NSString *description)
1515
{
@@ -22,10 +22,10 @@
2222
origin:SentryTraceOriginAutoAppStart
2323
sampled:tracer.sampled];
2424

25-
return [[SentrySpan alloc] initWithTracer:tracer context:context framesTracker:nil];
25+
return [[SentrySpanInternal alloc] initWithTracer:tracer context:context framesTracker:nil];
2626
}
2727

28-
NSArray<SentrySpan *> *
28+
NSArray<SentrySpanInternal *> *
2929
sentryBuildAppStartSpans(
3030
SentryTracer *tracer, SentryAppStartMeasurement *_Nullable appStartMeasurement)
3131
{
@@ -50,44 +50,45 @@
5050
return @[];
5151
}
5252

53-
NSMutableArray<SentrySpan *> *appStartSpans = [NSMutableArray array];
53+
NSMutableArray<SentrySpanInternal *> *appStartSpans = [NSMutableArray array];
5454

5555
NSDate *appStartEndTimestamp = [appStartMeasurement.appStartTimestamp
5656
dateByAddingTimeInterval:appStartMeasurement.duration];
5757

58-
SentrySpan *appStartSpan = sentryBuildAppStartSpan(tracer, tracer.spanId, operation, type);
58+
SentrySpanInternal *appStartSpan
59+
= sentryBuildAppStartSpan(tracer, tracer.spanId, operation, type);
5960
[appStartSpan setStartTimestamp:appStartMeasurement.appStartTimestamp];
6061
[appStartSpan setTimestamp:appStartEndTimestamp];
6162

6263
[appStartSpans addObject:appStartSpan];
6364

6465
if (!appStartMeasurement.isPreWarmed) {
65-
SentrySpan *premainSpan
66+
SentrySpanInternal *premainSpan
6667
= sentryBuildAppStartSpan(tracer, appStartSpan.spanId, operation, @"Pre Runtime Init");
6768
[premainSpan setStartTimestamp:appStartMeasurement.appStartTimestamp];
6869
[premainSpan setTimestamp:appStartMeasurement.runtimeInitTimestamp];
6970
[appStartSpans addObject:premainSpan];
7071

71-
SentrySpan *runtimeInitSpan = sentryBuildAppStartSpan(
72+
SentrySpanInternal *runtimeInitSpan = sentryBuildAppStartSpan(
7273
tracer, appStartSpan.spanId, operation, @"Runtime Init to Pre Main Initializers");
7374
[runtimeInitSpan setStartTimestamp:appStartMeasurement.runtimeInitTimestamp];
7475
[runtimeInitSpan setTimestamp:appStartMeasurement.moduleInitializationTimestamp];
7576
[appStartSpans addObject:runtimeInitSpan];
7677
}
7778

78-
SentrySpan *appInitSpan
79+
SentrySpanInternal *appInitSpan
7980
= sentryBuildAppStartSpan(tracer, appStartSpan.spanId, operation, @"UIKit Init");
8081
[appInitSpan setStartTimestamp:appStartMeasurement.moduleInitializationTimestamp];
8182
[appInitSpan setTimestamp:appStartMeasurement.sdkStartTimestamp];
8283
[appStartSpans addObject:appInitSpan];
8384

84-
SentrySpan *didFinishLaunching
85+
SentrySpanInternal *didFinishLaunching
8586
= sentryBuildAppStartSpan(tracer, appStartSpan.spanId, operation, @"Application Init");
8687
[didFinishLaunching setStartTimestamp:appStartMeasurement.sdkStartTimestamp];
8788
[didFinishLaunching setTimestamp:appStartMeasurement.didFinishLaunchingTimestamp];
8889
[appStartSpans addObject:didFinishLaunching];
8990

90-
SentrySpan *frameRenderSpan
91+
SentrySpanInternal *frameRenderSpan
9192
= sentryBuildAppStartSpan(tracer, appStartSpan.spanId, operation, @"Initial Frame Render");
9293
[frameRenderSpan setStartTimestamp:appStartMeasurement.didFinishLaunchingTimestamp];
9394
[frameRenderSpan setTimestamp:appStartEndTimestamp];

Sources/Sentry/SentryCoreDataTracker.m

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#import "SentryPredicateDescriptor.h"
99
#import "SentrySDK+Private.h"
1010
#import "SentryScope+Private.h"
11-
#import "SentrySpan.h"
11+
#import "SentrySpanInternal.h"
1212
#import "SentrySpanOperation.h"
1313
#import "SentrySpanProtocol.h"
1414
#import "SentryStacktrace.h"
@@ -37,8 +37,9 @@ - (NSArray *)managedObjectContext:(NSManagedObjectContext *)context
3737
error:(NSError **)error
3838
originalImp:(NSArray *(NS_NOESCAPE ^)(NSFetchRequest *, NSError **))original
3939
{
40-
id<SentrySpan> _Nullable currentSpan = [SentrySDKInternal.currentHub.scope span];
41-
id<SentrySpan> _Nullable fetchSpan;
40+
SentrySpanInternal *_Nullable currentSpan
41+
= (SentrySpanInternal *_Nullable)[SentrySDKInternal.currentHub.scope span];
42+
SentrySpanInternal *_Nullable fetchSpan;
4243
if (currentSpan) {
4344
NSString *spanDescription = [self descriptionFromRequest:request];
4445
fetchSpan = [currentSpan startChildWithOperation:SentrySpanOperationCoredataFetchOperation
@@ -56,7 +57,7 @@ - (NSArray *)managedObjectContext:(NSManagedObjectContext *)context
5657
NSArray *result = original(request, error);
5758

5859
if (fetchSpan) {
59-
[self addExtraInfoToSpan:(SentrySpan *)fetchSpan withContext:context];
60+
[self addExtraInfoToSpan:fetchSpan withContext:context];
6061

6162
[fetchSpan setDataValue:[NSNumber numberWithInteger:result.count] forKey:@"read_count"];
6263
[fetchSpan
@@ -103,7 +104,7 @@ - (BOOL)managedObjectContext:(NSManagedObjectContext *)context
103104
BOOL result = original(error);
104105

105106
if (saveSpan) {
106-
[self addExtraInfoToSpan:(SentrySpan *)saveSpan withContext:context];
107+
[self addExtraInfoToSpan:saveSpan withContext:context];
107108
[saveSpan finishWithStatus:result ? kSentrySpanStatusOk : kSentrySpanStatusInternalError];
108109

109110
SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically finished span with status: %@",
@@ -113,7 +114,7 @@ - (BOOL)managedObjectContext:(NSManagedObjectContext *)context
113114
return result;
114115
}
115116

116-
- (void)addExtraInfoToSpan:(SentrySpan *)span withContext:(NSManagedObjectContext *)context
117+
- (void)addExtraInfoToSpan:(SentrySpanInternal *)span withContext:(NSManagedObjectContext *)context
117118
{
118119
BOOL isMainThread = [NSThread isMainThread];
119120

Sources/Sentry/SentryCrashIntegration.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#import "SentrySDK+Private.h"
1111
#import "SentryScope+Private.h"
1212
#import "SentryScope+PrivateSwift.h"
13-
#import "SentrySpan+Private.h"
13+
#import "SentrySpanInternal+Private.h"
1414
#import "SentrySwift.h"
1515
#import "SentryTracer.h"
1616
#import <SentryClient+Private.h>
@@ -34,7 +34,7 @@
3434
void
3535
sentry_finishAndSaveTransaction(void)
3636
{
37-
SentrySpan *span = [SentrySDKInternal.currentHub.scope getCastedInternalSpan];
37+
SentrySpanInternal *_Nullable span = [SentrySDKInternal.currentHub.scope getCastedInternalSpan];
3838

3939
if (span != nil) {
4040
SentryTracer *tracer = [span tracer];

Sources/Sentry/SentryDefaultUIViewControllerPerformanceTracker.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ - (void)startRootSpanFor:(UIViewController *)controller
204204
}
205205

206206
spanId = [self getSpanIdForViewController:controller];
207-
SentrySpan *_Nullable vcSpan
208-
= (SentrySpan *)[self.tracker getSpan:SENTRY_UNWRAP_NULLABLE(SentrySpanId, spanId)];
207+
SentrySpanInternal *_Nullable vcSpan
208+
= (SentrySpanInternal *)[self.tracker getSpan:SENTRY_UNWRAP_NULLABLE(SentrySpanId, spanId)];
209209

210210
if (![vcSpan isKindOfClass:[SentryTracer self]]) {
211211
// Since TTID and TTFD are meant to the whole screen

Sources/Sentry/SentryFileIOTrackerHelper.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
#import "SentryLogC.h"
88
#import "SentrySDK+Private.h"
99
#import "SentryScope+Private.h"
10-
#import "SentrySpan.h"
1110
#import "SentrySpanDataKey.h"
11+
#import "SentrySpanInternal.h"
1212
#import "SentrySpanOperation.h"
1313
#import "SentrySpanProtocol.h"
1414
#import "SentryStacktrace.h"
@@ -246,7 +246,7 @@ - (void)mainThreadExtraInfo:(id<SentrySpan>)span
246246
// and we should not report it as an issue.
247247
[span setDataValue:@(NO) forKey:SPAN_DATA_BLOCKED_MAIN_THREAD];
248248
} else {
249-
[((SentrySpan *)span) setFrames:frames];
249+
[((SentrySpanInternal *)span) setFrames:frames];
250250
}
251251
}
252252

Sources/Sentry/SentryPerformanceTracker.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
#import "SentryLogC.h"
44
#import "SentrySDK+Private.h"
55
#import "SentryScope.h"
6-
#import "SentrySpan.h"
76
#import "SentrySpanId.h"
7+
#import "SentrySpanInternal.h"
88
#import "SentrySpanProtocol.h"
99
#import "SentryTracer.h"
1010
#import "SentryTracerConfiguration.h"

Sources/Sentry/SentrySDKInternal.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#import "SentryScope.h"
2020
#import "SentrySerialization.h"
2121
#import "SentrySessionReplayIntegration.h"
22+
#import "SentrySpanInternal.h"
2223
#import "SentrySwift.h"
2324
#import "SentryTransactionContext.h"
2425
#import "SentryUseNSExceptionCallstackWrapper.h"

0 commit comments

Comments
 (0)