-
-
Notifications
You must be signed in to change notification settings - Fork 363
ref: SentryEnvelopeHeader to swift #5454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
=============================================
+ Coverage 86.625% 86.756% +0.130%
=============================================
Files 427 428 +1
Lines 36870 36901 +31
Branches 15807 17419 +1612
=============================================
+ Hits 31939 32014 +75
+ Misses 4891 4842 -49
- Partials 40 45 +5
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
effeafa | 1225.88 ms | 1249.78 ms | 23.90 ms |
2137530 | 1223.39 ms | 1253.25 ms | 29.86 ms |
5d238d3 | 1228.94 ms | 1253.04 ms | 24.10 ms |
efa740d | 1220.71 ms | 1246.20 ms | 25.50 ms |
d157d83 | 1228.02 ms | 1252.47 ms | 24.45 ms |
5db87fa | 1218.88 ms | 1251.53 ms | 32.65 ms |
139db8b | 1231.50 ms | 1258.19 ms | 26.69 ms |
83bb978 | 1238.33 ms | 1260.04 ms | 21.71 ms |
891fd1d | 1220.02 ms | 1227.60 ms | 7.57 ms |
2de3f92 | 1207.56 ms | 1234.96 ms | 27.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
effeafa | 23.74 KiB | 926.64 KiB | 902.89 KiB |
2137530 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
5d238d3 | 23.75 KiB | 913.62 KiB | 889.88 KiB |
efa740d | 23.75 KiB | 919.69 KiB | 895.95 KiB |
d157d83 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
5db87fa | 23.75 KiB | 926.65 KiB | 902.90 KiB |
139db8b | 23.75 KiB | 920.64 KiB | 896.89 KiB |
83bb978 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
891fd1d | 23.75 KiB | 919.92 KiB | 896.17 KiB |
2de3f92 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
Previous results on branch: envelopeHeaderSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1532434 | 1231.52 ms | 1259.47 ms | 27.95 ms |
fdf2ea8 | 1218.63 ms | 1251.82 ms | 33.18 ms |
cbea941 | 1237.08 ms | 1259.14 ms | 22.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1532434 | 23.75 KiB | 947.72 KiB | 923.97 KiB |
fdf2ea8 | 23.75 KiB | 858.40 KiB | 834.64 KiB |
cbea941 | 23.75 KiB | 947.72 KiB | 923.97 KiB |
81f011c
to
3b3560f
Compare
d0f9518
to
c85b627
Compare
1b0eb72
to
82ec5ad
Compare
3b3560f
to
32b9522
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
32b9522
to
27833c6
Compare
27833c6
to
14b87bf
Compare
14b87bf
to
7f1c719
Compare
init(id eventId: SentryId?, sdkInfo: SentrySdkInfo?, traceContext: TraceContext?) { | ||
self.eventId = eventId | ||
self.sdkInfo = sdkInfo | ||
self.traceContext = traceContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No super.init here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's implicit in swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converts
SentryEnvelopeHeader
to Swift#skip-changelog