Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Jul 23, 2025

Fixes building XCFramework with 15.4

Running the CI, do not merge

@itaybre itaybre added the dontmerge A branch that absolutely should not be merged while this label is applied. label Jul 23, 2025
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix build with 15.4 issue ([#5695](https://github.com/getsentry/sentry-cocoa/pull/5695))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8681c49

Copy link

codecov bot commented Jul 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3790 1 3789 13
View the full list of 1 ❄️ flaky tests
SentryTests.SentrySDKInternalTests::testStartOnTheMainThread

Flake rate in main: 21.62% (Passed 29 times, Failed 8 times)

Stack Traces | 0s run time
.../Tests/SentryTests/SentrySDKInternalTests.swift:706 - Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "MainThreadTestIntegration install called".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@itaybre itaybre force-pushed the itay/nsdata_public_api branch from 776445c to 8681c49 Compare July 24, 2025 03:02
@itaybre itaybre marked this pull request as draft July 24, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dontmerge A branch that absolutely should not be merged while this label is applied.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant