-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat: Add source context and vars fields to SentryFrame #5853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5853 +/- ##
=========================================
Coverage 86.686% 86.687%
=========================================
Files 423 423
Lines 36527 36537 +10
Branches 17281 17288 +7
=========================================
+ Hits 31664 31673 +9
- Misses 4815 4819 +4
+ Partials 48 45 -3
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix the missing assertion.
I'll approve it, but I would also appreciate @philipphofmann take a look to confirm the changes, as they are public facing.
Missing decoding test check addressed in 158d1e0 |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
409a607 | 1229.57 ms | 1251.45 ms | 21.88 ms |
f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
102cf89 | 1218.31 ms | 1239.78 ms | 21.47 ms |
7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
1b9991e | 1233.45 ms | 1256.61 ms | 23.17 ms |
cd9727b | 1236.04 ms | 1254.41 ms | 18.37 ms |
15c8cd5 | 1220.24 ms | 1246.14 ms | 25.90 ms |
db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
409a607 | 23.74 KiB | 874.08 KiB | 850.33 KiB |
f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
102cf89 | 23.74 KiB | 891.02 KiB | 867.27 KiB |
7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
1b9991e | 23.75 KiB | 908.01 KiB | 884.26 KiB |
cd9727b | 23.75 KiB | 879.25 KiB | 855.51 KiB |
15c8cd5 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
Previous results on branch: feat/add-frame-source-context
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b915d28 | 1218.52 ms | 1243.54 ms | 25.02 ms |
8954159 | 1223.75 ms | 1236.84 ms | 13.09 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b915d28 | 23.75 KiB | 920.62 KiB | 896.87 KiB |
8954159 | 23.75 KiB | 920.34 KiB | 896.59 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
📜 Description
This PR introduces new fields to the
SentryFrame
class:contextLine
,preContext
,postContext
, andvars
.💡 Motivation and Context
These changes are needed for the Godot SDK to be able to capture script context and variables on iOS and macOS. We already have a similar setup with Sentry Native and Sentry Android backends.
Before this PR:
After this PR:
💚 How did you test it?
I’ve added unit tests.
Additionally, I used the WIP branch in Godot SDK to verify this functionality with a local Cocoa SDK build: getsentry/sentry-godot#306. The screenshot above was made using the linked branch.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.