Skip to content

Conversation

noahsmartin
Copy link
Contributor

This must have accidentally been made public, let's fix that in V9

#skip-changelog

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5c6f009

@noahsmartin noahsmartin force-pushed the removeRedactViewAPI branch from 59bc817 to fc6362d Compare August 8, 2025 19:53
Copy link

codecov bot commented Aug 8, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
32243 2 32241 97
View the top 2 failed test(s) by shortest run time
SentryTests.SentrySessionReplayIntegrationTests::testBufferReplayIgnoredBecauseSampleRateForCrash
Stack Traces | 0s run time
.../Integrations/SessionReplay/SentrySessionReplayIntegrationTests.swift:284 - Fulfilled inverted expectation "Replay to be captured".
iOS_ObjectiveC_UITests.LaunchUITests::testLaunch
Stack Traces | 0s run time
.../iOS-ObjectiveC/iOS-ObjectiveC-UITests/LaunchUITests.swift:12 - Application 'io.sentry.iOS-ObjectiveC' does not have a process ID

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.59 ms 1255.51 ms 27.92 ms
Size 23.75 KiB 926.64 KiB 902.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9e0030e 1222.78 ms 1242.23 ms 19.45 ms
b57ee62 1218.21 ms 1248.94 ms 30.73 ms
605fa27 1226.31 ms 1251.35 ms 25.05 ms
8d944ac 1236.92 ms 1254.91 ms 18.00 ms
1fe932f 1231.92 ms 1253.44 ms 21.52 ms
65ebbdb 1233.96 ms 1255.79 ms 21.83 ms
43597ba 1214.88 ms 1243.52 ms 28.65 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
65f8d2e 1221.15 ms 1243.96 ms 22.81 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms

App size

Revision Plain With Sentry Diff
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB
b57ee62 23.75 KiB 912.47 KiB 888.72 KiB
605fa27 23.75 KiB 908.03 KiB 884.28 KiB
8d944ac 23.75 KiB 919.69 KiB 895.94 KiB
1fe932f 23.75 KiB 913.63 KiB 889.88 KiB
65ebbdb 23.75 KiB 902.33 KiB 878.59 KiB
43597ba 23.75 KiB 880.32 KiB 856.58 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
65f8d2e 23.74 KiB 872.67 KiB 848.93 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB

Previous results on branch: removeRedactViewAPI

Startup times

Revision Plain With Sentry Diff
0ac7d55 1216.71 ms 1235.31 ms 18.60 ms
e49f340 1226.61 ms 1255.63 ms 29.02 ms
efca979 1235.53 ms 1266.22 ms 30.69 ms
6ae658b 1231.91 ms 1251.63 ms 19.72 ms

App size

Revision Plain With Sentry Diff
0ac7d55 23.75 KiB 926.64 KiB 902.89 KiB
e49f340 23.75 KiB 913.71 KiB 889.97 KiB
efca979 23.75 KiB 920.82 KiB 897.07 KiB
6ae658b 23.75 KiB 913.70 KiB 889.95 KiB

@noahsmartin noahsmartin force-pushed the removeRedactViewAPI branch from fc6362d to 7ad0d33 Compare August 8, 2025 20:28
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I double-checked an you are correct, but I did find this PR comment about changing it to be public:
https://github.com/getsentry/sentry-cocoa/pull/4392/files#r1784344132

image

@philprime
Copy link
Member

Maybe we should also add a changelog entry just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants