-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat: Add build type for adhoc #6044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add build type for adhoc #6044
Conversation
…enterprise-build-types
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6044 +/- ##
=============================================
- Coverage 86.774% 86.739% -0.036%
=============================================
Files 425 426 +1
Lines 36741 36800 +59
Branches 17366 17380 +14
=============================================
+ Hits 31882 31920 +38
- Misses 4814 4834 +20
- Partials 45 46 +1
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…build-types' of github.com:getsentry/sentry-cocoa into itay/cocoa-581-adhoc-builds-are-reported-as-enterprise-build-types
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
5ec90e0 | 1235.57 ms | 1258.45 ms | 22.88 ms |
04ff3ec | 1220.71 ms | 1253.86 ms | 33.15 ms |
67e8e3e | 1220.08 ms | 1229.23 ms | 9.15 ms |
b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms |
51b7dd3 | 1235.06 ms | 1258.21 ms | 23.15 ms |
b57ee62 | 1218.21 ms | 1248.94 ms | 30.73 ms |
884b224 | 1233.41 ms | 1259.50 ms | 26.09 ms |
7fc6927 | 1221.21 ms | 1242.36 ms | 21.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
5ec90e0 | 23.74 KiB | 872.67 KiB | 848.92 KiB |
04ff3ec | 23.75 KiB | 880.26 KiB | 856.52 KiB |
67e8e3e | 23.75 KiB | 919.91 KiB | 896.16 KiB |
b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB |
51b7dd3 | 23.75 KiB | 913.26 KiB | 889.52 KiB |
b57ee62 | 23.75 KiB | 912.47 KiB | 888.72 KiB |
884b224 | 23.75 KiB | 879.60 KiB | 855.86 KiB |
7fc6927 | 23.75 KiB | 908.54 KiB | 884.79 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @itaybre. I think we can improve the code a bit, so I added a few comments. I think this is a great opportunity to do some pair programming, so we both learn from each other. Otherwise, I see a bit of a risk of ping pong comments.
Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m
Outdated
Show resolved
Hide resolved
Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few suggestions.
📜 Description
Adds a new build type
adhoc
based on the embedded mobileprovision profile content.💡 Motivation and Context
Fixes: #6009
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.