Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 1, 2025

📜 Description

Adds a new build type adhoc based on the embedded mobileprovision profile content.

💡 Motivation and Context

Fixes: #6009

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link

linear bot commented Sep 1, 2025

@itaybre itaybre marked this pull request as ready for review September 1, 2025 19:13
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c44fb03

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.739%. Comparing base (2137530) to head (c44fb03).
⚠️ Report is 17 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ces/Swift/Helper/SentryMobileProvisionParser.swift 85.185% 8 Missing ⚠️
...ash/Recording/Monitors/SentryCrashMonitor_System.m 0.000% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6044       +/-   ##
=============================================
- Coverage   86.774%   86.739%   -0.036%     
=============================================
  Files          425       426        +1     
  Lines        36741     36800       +59     
  Branches     17366     17380       +14     
=============================================
+ Hits         31882     31920       +38     
- Misses        4814      4834       +20     
- Partials        45        46        +1     
Files with missing lines Coverage Δ
...ash/Recording/Monitors/SentryCrashMonitor_System.m 72.727% <0.000%> (+0.438%) ⬆️
...ces/Swift/Helper/SentryMobileProvisionParser.swift 85.185% <85.185%> (ø)

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2137530...c44fb03. Read the comment docs.

…build-types' of github.com:getsentry/sentry-cocoa into itay/cocoa-581-adhoc-builds-are-reported-as-enterprise-build-types
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.67 ms 1255.86 ms 22.19 ms
Size 23.75 KiB 941.78 KiB 918.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
aa96485 1215.37 ms 1234.04 ms 18.67 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
04ff3ec 1220.71 ms 1253.86 ms 33.15 ms
67e8e3e 1220.08 ms 1229.23 ms 9.15 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
51b7dd3 1235.06 ms 1258.21 ms 23.15 ms
b57ee62 1218.21 ms 1248.94 ms 30.73 ms
884b224 1233.41 ms 1259.50 ms 26.09 ms
7fc6927 1221.21 ms 1242.36 ms 21.15 ms

App size

Revision Plain With Sentry Diff
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
04ff3ec 23.75 KiB 880.26 KiB 856.52 KiB
67e8e3e 23.75 KiB 919.91 KiB 896.16 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
51b7dd3 23.75 KiB 913.26 KiB 889.52 KiB
b57ee62 23.75 KiB 912.47 KiB 888.72 KiB
884b224 23.75 KiB 879.60 KiB 855.86 KiB
7fc6927 23.75 KiB 908.54 KiB 884.79 KiB

Previous results on branch: itay/cocoa-581-adhoc-builds-are-reported-as-enterprise-build-types

Startup times

Revision Plain With Sentry Diff
990e6e0 1220.12 ms 1244.28 ms 24.15 ms

App size

Revision Plain With Sentry Diff
990e6e0 23.75 KiB 935.35 KiB 911.60 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @itaybre. I think we can improve the code a bit, so I added a few comments. I think this is a great opportunity to do some pair programming, so we both learn from each other. Otherwise, I see a bit of a risk of ping pong comments.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few suggestions.

@itaybre itaybre merged commit 8f2120f into main Sep 3, 2025
177 of 178 checks passed
@itaybre itaybre deleted the itay/cocoa-581-adhoc-builds-are-reported-as-enterprise-build-types branch September 3, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adhoc builds are reported as enterprise build types
2 participants