Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 2, 2025

📜 Description

Add a validation step after building the xcframework to double check the XCFramework structure.

💡 Motivation and Context

macOS requires a very specific versioned format which is prone to breaking.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

Copy link

linear bot commented Sep 2, 2025

@itaybre
Copy link
Contributor Author

itaybre commented Sep 2, 2025

The issue will be fixed after merging: #6049

Copy link

codecov bot commented Sep 2, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
163 1 162 0
View the full list of 1 ❄️ flaky tests
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp

Flake rate in main: 11.19% (Passed 127 times, Failed 16 times)

Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@itaybre itaybre marked this pull request as ready for review September 2, 2025 15:37
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.69 ms 1246.83 ms 22.15 ms
Size 23.75 KiB 933.33 KiB 909.58 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5196f0d 1213.35 ms 1231.37 ms 18.02 ms
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms
af7a86c 1220.82 ms 1243.36 ms 22.54 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms
718c372 1220.09 ms 1235.15 ms 15.06 ms
52f3b6e 1219.57 ms 1239.70 ms 20.13 ms
db9572a 1223.13 ms 1241.60 ms 18.47 ms
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
3067c23 1230.48 ms 1257.90 ms 27.42 ms
9ec4c56 1222.69 ms 1248.77 ms 26.08 ms

App size

Revision Plain With Sentry Diff
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB
af7a86c 23.74 KiB 926.65 KiB 902.90 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB
718c372 23.75 KiB 920.65 KiB 896.90 KiB
52f3b6e 23.75 KiB 920.54 KiB 896.79 KiB
db9572a 23.75 KiB 858.64 KiB 834.89 KiB
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
3067c23 23.75 KiB 928.15 KiB 904.40 KiB
9ec4c56 23.75 KiB 921.20 KiB 897.45 KiB

Previous results on branch: itay/cocoa-594-8550-release-has-invalid-framework-structure-on-macos

Startup times

Revision Plain With Sentry Diff
8212c0c 1219.57 ms 1238.55 ms 18.98 ms

App size

Revision Plain With Sentry Diff
8212c0c 23.75 KiB 933.33 KiB 909.58 KiB

@itaybre itaybre enabled auto-merge (squash) September 2, 2025 16:33
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this, I tested it locally with the broken frameworks of 8.55.0 and it reports the issues as expected.

LGTM!

@itaybre itaybre merged commit 00d9740 into main Sep 3, 2025
137 of 139 checks passed
@itaybre itaybre deleted the itay/cocoa-594-8550-release-has-invalid-framework-structure-on-macos branch September 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants