-
-
Notifications
You must be signed in to change notification settings - Fork 363
chore(ci): Validate XCFramework structure #6048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Validate XCFramework structure #6048
Conversation
The issue will be fixed after merging: #6049 |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
…ework-structure-on-macos
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
af7a86c | 1220.82 ms | 1243.36 ms | 22.54 ms |
c63e0fe | 1230.58 ms | 1253.94 ms | 23.35 ms |
718c372 | 1220.09 ms | 1235.15 ms | 15.06 ms |
52f3b6e | 1219.57 ms | 1239.70 ms | 20.13 ms |
db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
3067c23 | 1230.48 ms | 1257.90 ms | 27.42 ms |
9ec4c56 | 1222.69 ms | 1248.77 ms | 26.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
af7a86c | 23.74 KiB | 926.65 KiB | 902.90 KiB |
c63e0fe | 23.74 KiB | 874.08 KiB | 850.33 KiB |
718c372 | 23.75 KiB | 920.65 KiB | 896.90 KiB |
52f3b6e | 23.75 KiB | 920.54 KiB | 896.79 KiB |
db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
3067c23 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
9ec4c56 | 23.75 KiB | 921.20 KiB | 897.45 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this, I tested it locally with the broken frameworks of 8.55.0 and it reports the issues as expected.
LGTM!
📜 Description
Add a validation step after building the xcframework to double check the XCFramework structure.
💡 Motivation and Context
macOS requires a very specific versioned format which is prone to breaking.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.#skip-changelog