-
-
Notifications
You must be signed in to change notification settings - Fork 363
chore: Clean up workflow file filters #6050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up workflow file filters #6050
Conversation
Co-authored-by: phil.niedertscheider <[email protected]>
Cursor Agent can help with this pull request. Just |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6cb4338 | 1238.47 ms | 1256.96 ms | 18.49 ms |
55f739c | 1226.06 ms | 1248.78 ms | 22.71 ms |
ae7be93 | 1236.24 ms | 1258.18 ms | 21.94 ms |
2675d3c | 1218.94 ms | 1239.36 ms | 20.42 ms |
3c86ff3 | 1227.82 ms | 1239.73 ms | 11.91 ms |
7eafbde | 1212.16 ms | 1243.64 ms | 31.48 ms |
01faa71 | 1238.81 ms | 1263.98 ms | 25.17 ms |
2a6f451 | 1212.89 ms | 1237.45 ms | 24.56 ms |
fac4ca3 | 1222.81 ms | 1235.83 ms | 13.02 ms |
5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6cb4338 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
55f739c | 23.75 KiB | 858.73 KiB | 834.98 KiB |
ae7be93 | 23.75 KiB | 879.24 KiB | 855.49 KiB |
2675d3c | 23.75 KiB | 928.16 KiB | 904.41 KiB |
3c86ff3 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
7eafbde | 23.75 KiB | 927.53 KiB | 903.78 KiB |
01faa71 | 23.75 KiB | 926.77 KiB | 903.02 KiB |
2a6f451 | 23.75 KiB | 913.13 KiB | 889.38 KiB |
fac4ca3 | 23.75 KiB | 902.01 KiB | 878.27 KiB |
5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6050 +/- ##
========================================
Coverage ? 86.733%
========================================
Files ? 425
Lines ? 36748
Branches ? 17362
========================================
Hits ? 31873
Misses ? 4828
Partials ? 47 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already wanted to suggest doing a clean up as a follow up PR after all the other PRs. Thanks 🥇
📜 Description
Updated
.github/file-filters.yml
to ensure all GitHub Actions workflows trigger correctly based on relevant file changes. This involved adding missing dependencies, removing unused entries, and reorganizing the file for better consistency and readability.💡 Motivation and Context
The existing
file-filters.yml
contained inconsistencies, missing critical file dependencies (e.g., scripts, configuration files, test plans, transitive dependencies via Makefiles), and lacked a clear, consistent structure. This led to potential issues where workflows might not trigger when they should, or trigger unnecessarily. This PR addresses these issues to improve CI reliability, efficiency, and maintainability.💚 How did you test it?
A comprehensive analysis was performed by comparing all workflows in
.github/workflows
with the existing.github/file-filters.yml
. This included examining workflow path filters, script dependencies, Makefile targets, configuration files (e.g.,.clang-format
,dprint.json
,.swiftlint.yml
,xcconfig
,xctestplan
), and sample project files to identify and correct all inconsistencies and missing transitive dependencies.#skip-changelog
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.Slack Thread