Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Sep 2, 2025

📜 Description

Updated .github/file-filters.yml to ensure all GitHub Actions workflows trigger correctly based on relevant file changes. This involved adding missing dependencies, removing unused entries, and reorganizing the file for better consistency and readability.

💡 Motivation and Context

The existing file-filters.yml contained inconsistencies, missing critical file dependencies (e.g., scripts, configuration files, test plans, transitive dependencies via Makefiles), and lacked a clear, consistent structure. This led to potential issues where workflows might not trigger when they should, or trigger unnecessarily. This PR addresses these issues to improve CI reliability, efficiency, and maintainability.

💚 How did you test it?

A comprehensive analysis was performed by comparing all workflows in .github/workflows with the existing .github/file-filters.yml. This included examining workflow path filters, script dependencies, Makefile targets, configuration files (e.g., .clang-format, dprint.json, .swiftlint.yml, xcconfig, xctestplan), and sample project files to identify and correct all inconsistencies and missing transitive dependencies.

#skip-changelog

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes. (Note: This change is a configuration update based on analysis, not code requiring unit tests. The "test" was the analysis itself.)
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Slack Thread

Open in Cursor Open in Web

Copy link

cursor bot commented Sep 2, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@philprime philprime self-assigned this Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.80 ms 1244.78 ms 21.99 ms
Size 23.75 KiB 938.32 KiB 914.58 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6cb4338 1238.47 ms 1256.96 ms 18.49 ms
55f739c 1226.06 ms 1248.78 ms 22.71 ms
ae7be93 1236.24 ms 1258.18 ms 21.94 ms
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
3c86ff3 1227.82 ms 1239.73 ms 11.91 ms
7eafbde 1212.16 ms 1243.64 ms 31.48 ms
01faa71 1238.81 ms 1263.98 ms 25.17 ms
2a6f451 1212.89 ms 1237.45 ms 24.56 ms
fac4ca3 1222.81 ms 1235.83 ms 13.02 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms

App size

Revision Plain With Sentry Diff
6cb4338 23.75 KiB 913.63 KiB 889.88 KiB
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
ae7be93 23.75 KiB 879.24 KiB 855.49 KiB
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
3c86ff3 23.75 KiB 919.69 KiB 895.94 KiB
7eafbde 23.75 KiB 927.53 KiB 903.78 KiB
01faa71 23.75 KiB 926.77 KiB 903.02 KiB
2a6f451 23.75 KiB 913.13 KiB 889.38 KiB
fac4ca3 23.75 KiB 902.01 KiB 878.27 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB

Previous results on branch: cursor/synchronize-workflow-file-filters-and-dependencies-b5be

Startup times

Revision Plain With Sentry Diff
b6adfcd 1211.22 ms 1233.21 ms 21.98 ms

App size

Revision Plain With Sentry Diff
b6adfcd 23.75 KiB 933.33 KiB 909.58 KiB

@philprime philprime changed the title Synchronize workflow file filters and dependencies chore: Clean up workflow file filters Sep 3, 2025
@philprime philprime marked this pull request as ready for review September 3, 2025 07:28
Copy link
Contributor

github-actions bot commented Sep 3, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e446901). Learn more about missing BASE report.
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6050   +/-   ##
========================================
  Coverage        ?   86.733%           
========================================
  Files           ?       425           
  Lines           ?     36748           
  Branches        ?     17362           
========================================
  Hits            ?     31873           
  Misses          ?      4828           
  Partials        ?        47           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e446901...e9bd793. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already wanted to suggest doing a clean up as a follow up PR after all the other PRs. Thanks 🥇

@philprime philprime merged commit 348848e into main Sep 3, 2025
189 of 197 checks passed
@philprime philprime deleted the cursor/synchronize-workflow-file-filters-and-dependencies-b5be branch September 3, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants