Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 2, 2025

Rolls out hang tracker v2 for sdk v9
#skip-changelog

Closes #6335

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@16f6edc). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6334   +/-   ##
========================================
  Coverage        ?   86.850%           
========================================
  Files           ?       451           
  Lines           ?     37614           
  Branches        ?     17371           
========================================
  Hits            ?     32668           
  Misses          ?      4904           
  Partials        ?        42           
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 96.710% <100.000%> (ø)
Sources/Sentry/SentryBaseIntegration.m 95.625% <100.000%> (ø)
Sources/Sentry/SentryDependencyContainer.m 89.823% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 97.202% <100.000%> (ø)
Sources/Sentry/SentryProfiler.mm 90.449% <100.000%> (ø)
...try/SentryWatchdogTerminationTrackingIntegration.m 85.135% <100.000%> (ø)
Sources/Sentry/SentyOptionsInternal.m 99.673% <ø> (ø)
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f6edc...f222a22. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.43 ms 1262.72 ms 22.30 ms
Size 23.74 KiB 1022.30 KiB 998.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b6f8eb3 1217.94 ms 1246.57 ms 28.63 ms
8da82b4 1220.08 ms 1248.24 ms 28.16 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
ae79d35 1227.15 ms 1252.55 ms 25.41 ms
326984b 1235.06 ms 1252.75 ms 17.69 ms
16f6edc 1234.02 ms 1269.67 ms 35.65 ms
efa740d 1220.71 ms 1246.20 ms 25.50 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms

App size

Revision Plain With Sentry Diff
b6f8eb3 23.75 KiB 988.70 KiB 964.95 KiB
8da82b4 23.75 KiB 913.63 KiB 889.88 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
ae79d35 23.75 KiB 928.13 KiB 904.38 KiB
326984b 23.74 KiB 926.64 KiB 902.90 KiB
16f6edc 23.74 KiB 1022.94 KiB 999.19 KiB
efa740d 23.75 KiB 919.69 KiB 895.95 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB

Previous results on branch: removeHangTrackerV1

Startup times

Revision Plain With Sentry Diff
907b7a6 1216.52 ms 1255.84 ms 39.32 ms
29de0bb 1219.77 ms 1260.35 ms 40.58 ms
92ec0fa 1214.09 ms 1247.38 ms 33.29 ms
bbf9508 1219.44 ms 1258.17 ms 38.73 ms
910ea04 1226.04 ms 1264.50 ms 38.46 ms

App size

Revision Plain With Sentry Diff
907b7a6 23.75 KiB 1020.98 KiB 997.23 KiB
29de0bb 23.74 KiB 1022.30 KiB 998.55 KiB
92ec0fa 23.74 KiB 1022.30 KiB 998.55 KiB
bbf9508 23.74 KiB 1022.29 KiB 998.55 KiB
910ea04 23.75 KiB 1020.94 KiB 997.19 KiB

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the unit tests, but please @noahsmartin also review my changes. I'm going to approve this PR, cause you can't merge if I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove hang tracker sdk v9 checks

2 participants