-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore: Remove more codable v9 checks #6363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6363 +/- ##
=============================================
- Coverage 87.293% 86.794% -0.499%
=============================================
Files 438 438
Lines 37311 37311
Branches 17435 17427 -8
=============================================
- Hits 32570 32384 -186
- Misses 4696 4881 +185
- Partials 45 46 +1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
f6443c8
to
f3e004a
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8fd192f | 1202.10 ms | 1220.19 ms | 18.09 ms |
dad68ad | 1229.15 ms | 1261.98 ms | 32.83 ms |
1bf432b | 1200.22 ms | 1226.90 ms | 26.67 ms |
afaa522 | 1234.71 ms | 1256.19 ms | 21.48 ms |
ca91f42 | 1223.69 ms | 1249.14 ms | 25.45 ms |
649265b | 1235.16 ms | 1264.59 ms | 29.43 ms |
b045d0a | 1227.48 ms | 1252.22 ms | 24.75 ms |
7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
d83b35a | 1212.48 ms | 1237.02 ms | 24.54 ms |
65f8d2e | 1221.15 ms | 1243.96 ms | 22.81 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8fd192f | 23.74 KiB | 872.75 KiB | 849.01 KiB |
dad68ad | 23.75 KiB | 912.37 KiB | 888.63 KiB |
1bf432b | 23.75 KiB | 926.64 KiB | 902.90 KiB |
afaa522 | 23.74 KiB | 996.91 KiB | 973.17 KiB |
ca91f42 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
649265b | 23.75 KiB | 980.81 KiB | 957.06 KiB |
b045d0a | 23.75 KiB | 880.21 KiB | 856.46 KiB |
7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
d83b35a | 23.75 KiB | 913.17 KiB | 889.42 KiB |
65f8d2e | 23.74 KiB | 872.67 KiB | 848.93 KiB |
f3e004a
to
64b6657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removing the SDK_V9 checks here. This is already in the changelog from my previous PR
#skip-changelog
Closes #6364