Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 6, 2025

Removing the SDK_V9 checks here. This is already in the changelog from my previous PR

#skip-changelog

Closes #6364

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.794%. Comparing base (78af7a9) to head (64b6657).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6363       +/-   ##
=============================================
- Coverage   87.293%   86.794%   -0.499%     
=============================================
  Files          438       438               
  Lines        37311     37311               
  Branches     17435     17427        -8     
=============================================
- Hits         32570     32384      -186     
- Misses        4696      4881      +185     
- Partials        45        46        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryBreadcrumb.m 97.087% <100.000%> (ø)
Sources/Sentry/SentryGeo.m 95.000% <100.000%> (ø)
Sources/Sentry/SentryThread.mm 100.000% <ø> (ø)
...ift/Protocol/Codable/SentryBreadcrumbCodable.swift 100.000% <ø> (ø)
...es/Swift/Protocol/Codable/SentryEventCodable.swift 100.000% <ø> (ø)
...wift/Protocol/Codable/SentryExceptionCodable.swift 100.000% <ø> (ø)
...es/Swift/Protocol/Codable/SentryFrameCodable.swift 100.000% <ø> (ø)
...rces/Swift/Protocol/Codable/SentryGeoCodable.swift 100.000% <ø> (ø)
...wift/Protocol/Codable/SentryMechanismCodable.swift 100.000% <ø> (ø)
.../Protocol/Codable/SentryMechanismMetaCodable.swift 100.000% <ø> (ø)
... and 5 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78af7a9...64b6657. Read the comment docs.

@noahsmartin noahsmartin force-pushed the removeMoreV9ChecksCodable branch 6 times, most recently from f6443c8 to f3e004a Compare October 6, 2025 22:45
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.28 ms 1255.93 ms 32.65 ms
Size 23.75 KiB 991.79 KiB 968.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
dad68ad 1229.15 ms 1261.98 ms 32.83 ms
1bf432b 1200.22 ms 1226.90 ms 26.67 ms
afaa522 1234.71 ms 1256.19 ms 21.48 ms
ca91f42 1223.69 ms 1249.14 ms 25.45 ms
649265b 1235.16 ms 1264.59 ms 29.43 ms
b045d0a 1227.48 ms 1252.22 ms 24.75 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
d83b35a 1212.48 ms 1237.02 ms 24.54 ms
65f8d2e 1221.15 ms 1243.96 ms 22.81 ms

App size

Revision Plain With Sentry Diff
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
dad68ad 23.75 KiB 912.37 KiB 888.63 KiB
1bf432b 23.75 KiB 926.64 KiB 902.90 KiB
afaa522 23.74 KiB 996.91 KiB 973.17 KiB
ca91f42 23.75 KiB 913.63 KiB 889.88 KiB
649265b 23.75 KiB 980.81 KiB 957.06 KiB
b045d0a 23.75 KiB 880.21 KiB 856.46 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
d83b35a 23.75 KiB 913.17 KiB 889.42 KiB
65f8d2e 23.74 KiB 872.67 KiB 848.93 KiB

Previous results on branch: removeMoreV9ChecksCodable

Startup times

Revision Plain With Sentry Diff
85f864b 1228.33 ms 1260.24 ms 31.91 ms

App size

Revision Plain With Sentry Diff
85f864b 23.75 KiB 992.06 KiB 968.31 KiB

@noahsmartin noahsmartin force-pushed the removeMoreV9ChecksCodable branch from f3e004a to 64b6657 Compare October 7, 2025 02:49
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit c3d6cfa into main Oct 7, 2025
203 of 210 checks passed
@noahsmartin noahsmartin deleted the removeMoreV9ChecksCodable branch October 7, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove more codable v9 checks

2 participants