Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025

Wraps up the Swift migration by making the dependency container in Swift.

There are a huge number of files that #import "SentryDependencyContainer.h" So to make this PR easier to review I've left that file there, just empty, and will remove it in a follow up PR.

#skip-changelog

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 22.84768% with 233 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.592%. Comparing base (9c75c11) to head (b8e3db9).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/SentryDependencyContainer.swift 37.777% 112 Missing ⚠️
...Swift/Core/Integrations/ANR/SentryANRTracker.swift 0.000% 34 Missing ⚠️
...rces/Sentry/SentryDependencyContainerSwiftHelper.m 0.000% 23 Missing ⚠️
Sources/Sentry/SentryANRTrackerV2.m 0.000% 15 Missing ⚠️
Sources/Sentry/SentryDelayedFramesTracker.m 0.000% 14 Missing ⚠️
...tions/SentryWatchdogTerminationScopeObserver.swift 0.000% 12 Missing ⚠️
Sources/Sentry/SentryANRStoppedResultInternal.m 0.000% 8 Missing ⚠️
...tions/FramesTracking/SentryFramesDelayResult.swift 0.000% 5 Missing ⚠️
Sources/Sentry/SentryANRTrackerV1.m 0.000% 4 Missing ⚠️
...egrations/FramesTracking/SentryFramesTracker.swift 0.000% 4 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (9c75c11) and HEAD (b8e3db9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (9c75c11) HEAD (b8e3db9)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6444        +/-   ##
=============================================
- Coverage   87.007%   7.592%   -79.415%     
=============================================
  Files          452      417        -35     
  Lines        37790    36034      -1756     
  Branches     17478    14158      -3320     
=============================================
- Hits         32880     2736     -30144     
- Misses        4867    33287     +28420     
+ Partials        43       11        -32     
Files with missing lines Coverage Δ
Sources/Sentry/SentryDebugImageProviderInternal.m 15.476% <100.000%> (-65.701%) ⬇️
Sources/Swift/Helper/Dependencies.swift 100.000% <ø> (ø)
Sources/Sentry/SentrySpan.m 34.980% <0.000%> (-62.738%) ⬇️
Sources/Sentry/SentryTracer.m 56.862% <0.000%> (-41.340%) ⬇️
Sources/Sentry/SentryANRTrackerV1.m 0.000% <0.000%> (-93.894%) ⬇️
...egrations/FramesTracking/SentryFramesTracker.swift 15.492% <0.000%> (-84.508%) ⬇️
...tions/FramesTracking/SentryFramesDelayResult.swift 0.000% <0.000%> (-100.000%) ⬇️
Sources/Sentry/SentryANRStoppedResultInternal.m 0.000% <0.000%> (ø)
...tions/SentryWatchdogTerminationScopeObserver.swift 0.000% <0.000%> (ø)
Sources/Sentry/SentryDelayedFramesTracker.m 15.923% <0.000%> (-77.366%) ⬇️
... and 4 more

... and 423 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c75c11...b8e3db9. Read the comment docs.

@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch 14 times, most recently from 9d7cbdb to 63ac42f Compare October 20, 2025 18:20
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.00 ms 1270.52 ms 34.52 ms
Size 23.74 KiB 1.01 MiB 1007.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
d157d83 1228.02 ms 1252.47 ms 24.45 ms
6d40fee 1217.47 ms 1245.37 ms 27.90 ms
5218a05 1236.35 ms 1245.41 ms 9.06 ms
0ee162c 1226.90 ms 1261.72 ms 34.83 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
75b23cd 1227.10 ms 1253.61 ms 26.51 ms
1a820a1 1217.79 ms 1260.34 ms 42.55 ms
083e8c5 1227.74 ms 1262.37 ms 34.62 ms

App size

Revision Plain With Sentry Diff
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
6d40fee 23.75 KiB 912.37 KiB 888.63 KiB
5218a05 23.75 KiB 984.71 KiB 960.96 KiB
0ee162c 23.75 KiB 933.33 KiB 909.58 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
75b23cd 23.75 KiB 933.66 KiB 909.92 KiB
1a820a1 23.75 KiB 994.82 KiB 971.07 KiB
083e8c5 23.75 KiB 981.75 KiB 958.00 KiB

Previous results on branch: dependencyContainerSwift

Startup times

Revision Plain With Sentry Diff
1efc2cc 1237.15 ms 1271.24 ms 34.09 ms
2cca378 1231.40 ms 1256.67 ms 25.26 ms
e4f30fd 1223.00 ms 1265.11 ms 42.11 ms

App size

Revision Plain With Sentry Diff
1efc2cc 23.74 KiB 1.01 MiB 1007.12 KiB
2cca378 23.75 KiB 1.00 MiB 1004.86 KiB
e4f30fd 23.74 KiB 1.00 MiB 1005.70 KiB

@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch from 63ac42f to da7ca39 Compare October 20, 2025 18:54
@itaybre itaybre self-requested a review October 20, 2025 20:57
@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch 6 times, most recently from a668963 to 7057287 Compare October 21, 2025 01:02
@noahsmartin noahsmartin force-pushed the dependencyContainerSwift branch from 7057287 to b8e3db9 Compare October 21, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants