-
-
Notifications
You must be signed in to change notification settings - Fork 368
ref: Convert SentryANRTracker to class #6465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbd13ab
to
0a314aa
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6465 +/- ##
=============================================
+ Coverage 86.926% 87.478% +0.552%
=============================================
Files 450 452 +2
Lines 37619 37784 +165
Branches 17378 17489 +111
=============================================
+ Hits 32701 33053 +352
+ Misses 4876 4686 -190
- Partials 42 45 +3
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
93acb75
to
ca65ebb
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7123d8e | 1222.27 ms | 1262.02 ms | 39.76 ms |
5258fb8 | 1207.92 ms | 1234.51 ms | 26.59 ms |
07d7e83 | 1211.71 ms | 1240.08 ms | 28.37 ms |
be882e4 | 1199.35 ms | 1231.20 ms | 31.86 ms |
4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
7bd90de | 1233.48 ms | 1249.47 ms | 15.99 ms |
f4f94f5 | 1216.24 ms | 1247.94 ms | 31.70 ms |
7416ffc | 1225.55 ms | 1241.80 ms | 16.25 ms |
d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7123d8e | 23.75 KiB | 986.80 KiB | 963.05 KiB |
5258fb8 | 23.75 KiB | 874.45 KiB | 850.70 KiB |
07d7e83 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
be882e4 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
7bd90de | 23.75 KiB | 933.33 KiB | 909.58 KiB |
f4f94f5 | 23.75 KiB | 988.02 KiB | 964.27 KiB |
7416ffc | 23.75 KiB | 913.63 KiB | 889.88 KiB |
d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
ca65ebb
to
801a026
Compare
801a026
to
974c0f1
Compare
I pulled this change out of the overall dependency container Swift refactor to make that PR easier to review
#skip-changelog
Closes #6466