Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Dec 4, 2025

The only way this would ever report debug is if the code was built with the DEBUG preprocessor flag. But we support building from a pre-built binary which is pre-built in release mode (I hope) so this would not work. A more reliable way is to check the entitlements to see if it's a debug build.

#skip-changelog

Closes #6990

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Dec 4, 2025
options: [],
format: &format),
let dict = obj as? [String: Any] else {
return
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Tests use an old, non-existent property name, causing compilation errors.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The property mobileProvisionProfileProvisionsAllDevices was renamed to provisionsAllDevices in SentryMobileProvisionParser. While the Objective-C code was updated, 11 references in SentryMobileProvisionParserTests.swift still use the old property name. This will cause compilation errors in the test file, preventing the project from building successfully.

💡 Suggested Fix

Update all 11 occurrences of parser.mobileProvisionProfileProvisionsAllDevices in SentryMobileProvisionParserTests.swift to parser.provisionsAllDevices.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: Sources/Swift/Helper/SentryMobileProvisionParser.swift#L57

Potential issue: The property `mobileProvisionProfileProvisionsAllDevices` was renamed
to `provisionsAllDevices` in `SentryMobileProvisionParser`. While the Objective-C code
was updated, 11 references in `SentryMobileProvisionParserTests.swift` still use the old
property name. This will cause compilation errors in the test file, preventing the
project from building successfully.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5544207

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.064%. Comparing base (b2295d4) to head (bf18975).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% 5 Missing ⚠️
...ash/Recording/Monitors/SentryCrashMonitor_System.m 0.000% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b2295d4) and HEAD (bf18975). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b2295d4) HEAD (bf18975)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6989        +/-   ##
=============================================
- Coverage   85.076%   7.064%   -78.013%     
=============================================
  Files          453      418        -35     
  Lines        27674    26415      -1259     
  Branches     12166     9921      -2245     
=============================================
- Hits         23544     1866     -21678     
- Misses        4087    24536     +20449     
+ Partials        43       13        -30     
Files with missing lines Coverage Δ
...ash/Recording/Monitors/SentryCrashMonitor_System.m 70.512% <0.000%> (-1.470%) ⬇️
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% <0.000%> (-82.858%) ⬇️

... and 434 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2295d4...bf18975. Read the comment docs.

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add some tests to ensure future changes don't break anything?

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.064%. Comparing base (b2295d4) to head (bf18975).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% 5 Missing ⚠️
...ash/Recording/Monitors/SentryCrashMonitor_System.m 0.000% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b2295d4) and HEAD (bf18975). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b2295d4) HEAD (bf18975)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6989        +/-   ##
=============================================
- Coverage   85.076%   7.064%   -78.013%     
=============================================
  Files          453      418        -35     
  Lines        27674    26415      -1259     
  Branches     12166     9921      -2245     
=============================================
- Hits         23544     1866     -21678     
- Misses        4087    24536     +20449     
+ Partials        43       13        -30     
Files with missing lines Coverage Δ
...ash/Recording/Monitors/SentryCrashMonitor_System.m 70.512% <0.000%> (-1.470%) ⬇️
...ces/Swift/Helper/SentryMobileProvisionParser.swift 0.000% <0.000%> (-82.858%) ⬇️

... and 434 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2295d4...bf18975. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.87 ms 1244.18 ms 19.31 ms
Size 24.14 KiB 1.02 MiB 1020.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
37900c9 1236.06 ms 1262.22 ms 26.16 ms
929c622 1228.48 ms 1253.55 ms 25.07 ms
48e5c8a 1223.02 ms 1242.38 ms 19.35 ms
a598105 1236.51 ms 1258.88 ms 22.37 ms
319fb1e 1219.48 ms 1242.69 ms 23.21 ms
e98d6f5 1228.51 ms 1258.85 ms 30.34 ms
daeb716 1215.41 ms 1246.52 ms 31.11 ms
cd67f52 1216.29 ms 1255.27 ms 38.99 ms
e8e40fd 1222.10 ms 1259.91 ms 37.80 ms
78af7a9 1225.75 ms 1256.98 ms 31.23 ms

App size

Revision Plain With Sentry Diff
37900c9 23.75 KiB 958.61 KiB 934.85 KiB
929c622 24.14 KiB 1.02 MiB 1016.90 KiB
48e5c8a 23.75 KiB 913.63 KiB 889.88 KiB
a598105 23.75 KiB 968.24 KiB 944.49 KiB
319fb1e 23.75 KiB 1019.18 KiB 995.43 KiB
e98d6f5 23.75 KiB 933.03 KiB 909.28 KiB
daeb716 23.75 KiB 928.16 KiB 904.41 KiB
cd67f52 23.75 KiB 1.01 MiB 1016.04 KiB
e8e40fd 23.75 KiB 1022.79 KiB 999.04 KiB
78af7a9 23.75 KiB 990.00 KiB 966.26 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Development builds with prebuilt binary

3 participants