Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 5, 2025

Removes SentryPrivate.podspec since it has been unused for over a year.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3985 2 3983 24
View the top 2 failed test(s) by shortest run time
SentryTests.SentrySwiftIntegrationInstallerTests::testInstall_AddsInstalledIntegrations
Stack Traces | 0s run time
.../SentryTests/Integrations/SentrySwiftIntegrationInstallerTests.swift:28 - XCTAssertEqual failed: ("2") is not equal to ("1")
SentryTests.SentrySwiftIntegrationInstallerTests::testInstall_WithDisabledIntegration_DoesNotAddIntegration
Stack Traces | 0s run time
.../SentryTests/Integrations/SentrySwiftIntegrationInstallerTests.swift:47 - XCTAssertEqual failed: ("1") is not equal to ("0")

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.19 ms 1250.82 ms 31.62 ms
Size 24.14 KiB 1.02 MiB 1017.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c174e5e 1209.65 ms 1238.73 ms 29.08 ms
55f739c 1226.06 ms 1248.78 ms 22.71 ms
ad61b1d 1229.93 ms 1261.00 ms 31.07 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
588dd7c 1235.11 ms 1241.76 ms 6.65 ms
9ccc0f5 1227.59 ms 1264.07 ms 36.47 ms
2bddb03 1214.11 ms 1246.78 ms 32.67 ms
8047b99 1226.37 ms 1246.63 ms 20.26 ms
ed85746 1231.79 ms 1248.55 ms 16.75 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms

App size

Revision Plain With Sentry Diff
c174e5e 23.75 KiB 953.92 KiB 930.16 KiB
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
ad61b1d 24.15 KiB 1.01 MiB 1014.91 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
588dd7c 23.75 KiB 938.33 KiB 914.58 KiB
9ccc0f5 24.14 KiB 1.01 MiB 1014.11 KiB
2bddb03 23.75 KiB 891.01 KiB 867.26 KiB
8047b99 23.75 KiB 855.37 KiB 831.62 KiB
ed85746 23.75 KiB 920.83 KiB 897.08 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants