Convert SentryWatchdogTerminationIntegration to Swift
#7119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the Integration class from Objective-C to Swift, building on top of the previously migrated Logic and Tracker Swift classes. The Swift Integration uses a protocol-based dependency injection pattern for better testability. Changes: - Add SentryWatchdogTerminationTrackingIntegration.swift with generics - Remove old Objective-C Integration implementation - Update Integrations.swift to register the Swift integration - Update SentrySDKInternal.m to remove ObjC registration - Update Integration tests to work with new Swift implementation
Update the scope observer API to be more Swift-friendly. Rename addObserver to addScopeObserver and make it accept Any type with runtime validation, allowing Swift-defined protocols to work properly with Objective-C. Changes: - Rename addObserver: to addScopeObserver: in SentryScope - Update addScopeObserver to accept Any with runtime protocol checking - Remove addObserver from SentryScope+Private.h header - Add addScopeObserver to SentryScope+PrivateSwift.h - Update SentryCrashIntegration to use new API - Update tests to cast observer to Any when needed - Update Xcode project to include Integration Swift file
itaybre
commented
Jan 5, 2026
itaybre
commented
Jan 5, 2026
...s/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackingIntegration.swift
Outdated
Show resolved
Hide resolved
itaybre
force-pushed
the
ref/watchdog-integration-to-swift
branch
from
b6b35bb to
7145675
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ref/watchdog-logic-tracker-to-swift #7119 +/- ##
=========================================================================
- Coverage 84.739% 84.457% -0.282%
=========================================================================
Files 459 454 -5
Lines 27515 27383 -132
Branches 12111 11986 -125
=========================================================================
- Hits 23316 23127 -189
- Misses 4157 4209 +52
- Partials 42 47 +5
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Converts SentryWatchdogTerminationIntegration to Swift
💡 Motivation and Context
Less ObjC code, more Swift type safety
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog