-
-
Notifications
You must be signed in to change notification settings - Fork 375
fix: Encode SwiftUI internal class names in session replay redaction to prevent App Store rejections #7123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent App Store rejections
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e3fb04 | 1239.84 ms | 1267.39 ms | 27.55 ms |
| b66be9b | 1218.22 ms | 1244.19 ms | 25.96 ms |
| f73c5c8 | 1211.10 ms | 1234.62 ms | 23.51 ms |
| 237dfb1 | 1214.90 ms | 1258.63 ms | 43.73 ms |
| c21a31f | 1216.02 ms | 1236.34 ms | 20.32 ms |
| 3af1ae9 | 1225.60 ms | 1252.65 ms | 27.05 ms |
| c21a31f | 1237.04 ms | 1256.65 ms | 19.61 ms |
| 653de7c | 1205.02 ms | 1222.20 ms | 17.18 ms |
| e537c90 | 1226.22 ms | 1256.64 ms | 30.41 ms |
| 48dc176 | 1204.96 ms | 1237.73 ms | 32.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e3fb04 | 23.74 KiB | 981.30 KiB | 957.56 KiB |
| b66be9b | 23.75 KiB | 996.03 KiB | 972.28 KiB |
| f73c5c8 | 24.14 KiB | 1001.32 KiB | 977.18 KiB |
| 237dfb1 | 23.75 KiB | 1000.79 KiB | 977.04 KiB |
| c21a31f | 23.75 KiB | 1000.80 KiB | 977.05 KiB |
| 3af1ae9 | 23.74 KiB | 981.29 KiB | 957.55 KiB |
| c21a31f | 23.75 KiB | 1000.77 KiB | 977.02 KiB |
| 653de7c | 23.75 KiB | 992.25 KiB | 968.50 KiB |
| e537c90 | 23.75 KiB | 992.03 KiB | 968.28 KiB |
| 48dc176 | 24.14 KiB | 1001.34 KiB | 977.20 KiB |
7 tasks
philprime
approved these changes
Jan 8, 2026
Member
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to ensure our wording states that we are not trying to circumvent the review, just handling false-positives
Sources/Swift/Core/Tools/ViewCapture/SentryUIRedactBuilder.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Core/Tools/ViewCapture/SentryUIRedactBuilder.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Niedertscheider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Base64 encode a couple of Apple private classes to avoid triggering Apple's string verification
💡 Motivation and Context
Fixes: #7121
Apple seems to run some static checks when testing apps which detect some SwiftUI classes we try to avoid.
Encoding it, should fix the problem
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7126