Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Jan 7, 2026

📜 Description

Base64 encode a couple of Apple private classes to avoid triggering Apple's string verification

💡 Motivation and Context

Fixes: #7121

Apple seems to run some static checks when testing apps which detect some SwiftUI classes we try to avoid.
Encoding it, should fix the problem

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7126

@codecov
Copy link

codecov bot commented Jan 7, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4076 1 4075 17
View the top 2 failed test(s) by shortest run time
iOS_SwiftUI_UITests.LaunchUITests::testTransactionSpan
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:18 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testCaptureException
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:63 - Failed to terminate io.sentry.sample.iOS-Swift:11995: Failed to terminate io.sentry.sample.iOS-Swift:0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.61 ms 1248.67 ms 26.06 ms
Size 24.14 KiB 1001.66 KiB 977.52 KiB

Baseline results on branch: v8.x

Startup times

Revision Plain With Sentry Diff
5e3fb04 1239.84 ms 1267.39 ms 27.55 ms
b66be9b 1218.22 ms 1244.19 ms 25.96 ms
f73c5c8 1211.10 ms 1234.62 ms 23.51 ms
237dfb1 1214.90 ms 1258.63 ms 43.73 ms
c21a31f 1216.02 ms 1236.34 ms 20.32 ms
3af1ae9 1225.60 ms 1252.65 ms 27.05 ms
c21a31f 1237.04 ms 1256.65 ms 19.61 ms
653de7c 1205.02 ms 1222.20 ms 17.18 ms
e537c90 1226.22 ms 1256.64 ms 30.41 ms
48dc176 1204.96 ms 1237.73 ms 32.77 ms

App size

Revision Plain With Sentry Diff
5e3fb04 23.74 KiB 981.30 KiB 957.56 KiB
b66be9b 23.75 KiB 996.03 KiB 972.28 KiB
f73c5c8 24.14 KiB 1001.32 KiB 977.18 KiB
237dfb1 23.75 KiB 1000.79 KiB 977.04 KiB
c21a31f 23.75 KiB 1000.80 KiB 977.05 KiB
3af1ae9 23.74 KiB 981.29 KiB 957.55 KiB
c21a31f 23.75 KiB 1000.77 KiB 977.02 KiB
653de7c 23.75 KiB 992.25 KiB 968.50 KiB
e537c90 23.75 KiB 992.03 KiB 968.28 KiB
48dc176 24.14 KiB 1001.34 KiB 977.20 KiB

Previous results on branch: itay/encode_base64_class

Startup times

Revision Plain With Sentry Diff
2d3729e 1208.41 ms 1224.13 ms 15.72 ms

App size

Revision Plain With Sentry Diff
2d3729e 24.14 KiB 1001.66 KiB 977.52 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to ensure our wording states that we are not trying to circumvent the review, just handling false-positives

Co-authored-by: Philip Niedertscheider <[email protected]>
@itaybre itaybre enabled auto-merge (squash) January 8, 2026 12:42
@itaybre itaybre merged commit 784b102 into v8.x Jan 8, 2026
178 of 183 checks passed
@itaybre itaybre deleted the itay/encode_base64_class branch January 8, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants