Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Feb 10, 2026

📜 Description

Changes performed:

  • Disabled reachability callback so it doesn't generate breadcrumbs automatically during our tests
  • Fixed the test so it call the integration add(breadcrumb) instead of adding it to the SDK Manually

#skip-changelog

💡 Motivation and Context

Reachability breadcrumbs made the test flaky

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7426

…ntegrationTests and check integration registers generated breadcrumbs
@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.297%. Comparing base (c431600) to head (1cab77f).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7425       +/-   ##
=============================================
- Coverage   85.327%   85.297%   -0.031%     
=============================================
  Files          481       485        +4     
  Lines        28612     28859      +247     
  Branches     12440     12580      +140     
=============================================
+ Hits         24414     24616      +202     
- Misses        4153      4200       +47     
+ Partials        45        43        -2     

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c431600...1cab77f. Read the comment docs.

@itaybre itaybre merged commit 7bf2942 into main Feb 11, 2026
172 of 220 checks passed
@itaybre itaybre deleted the itay/fix_flaky_breadcrumb_test branch February 11, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-code-assisted ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(test): Disable reachability callbacks in SentryBreadcrumbTrackingIntegrationTests and check integration registers generated breadcrumbs

2 participants