-
-
Notifications
You must be signed in to change notification settings - Fork 378
Making setOutput in SentrySDKLog.swift public to make it possible to forward logs to the JS console
#7444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
logs to the JS console
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Other
🤖 This preview updates automatically when you update the PR. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Making `setOutput` in `SentrySDKLog.swift` public to make it possible to forward logs to the JS console ([#7444](https://github.com/getsentry/sentry-cocoa/pull/7444))If none of the above apply, you can opt out of this check by adding |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7444 +/- ##
=============================================
+ Coverage 85.335% 85.352% +0.017%
=============================================
Files 480 480
Lines 28620 28620
Branches 12376 12374 -2
=============================================
+ Hits 24423 24428 +5
+ Misses 4149 4144 -5
Partials 48 48
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be set through https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Sentry/Public/PrivateSentrySDKOnly.h
📜 Description
This PR adds one tiny change to the codebase — it makes
setOutputinSentrySDKLog.swiftpublic.That's required by RN SDK (and probably other hybrid SDKs as well) in order to support log forwarding — the ability to see native logs in JS console: getsentry/sentry-react-native#5622
(there are also some formatting changes done here but they were done automatically after I ran
make format)📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.