fix: Set installationId as fallback userId when user has no userId#7451
Open
asynclet wants to merge 1 commit intogetsentry:mainfrom
Open
fix: Set installationId as fallback userId when user has no userId#7451asynclet wants to merge 1 commit intogetsentry:mainfrom
asynclet wants to merge 1 commit intogetsentry:mainfrom
Conversation
When a user object exists with email/username but no userId, the iOS SDK now falls back to installationId, aligning with Android SDK behavior.
asynclet
requested review from
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Hey @asynclet, What do you think @philipphofmann @philprime ? We are in v9.4.1, should we add the change now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryUserobject exists with fields likeemail/usernamebut nouserId, the SDK now falls back toinstallationIdas the userId — aligning with Android SDK behaviorTest plan
testInstallationIdSetWhenUserIsSetWithoutIdto verify installationId is now set as fallbacktestInstallationIdNotSetWhenUserIsSetWithIdstill passes — explicit userId is not overwrittentestInstallationIdSetWhenNoUserIdstill passes — no-user case unchanged