-
-
Notifications
You must be signed in to change notification settings - Fork 385
chore: Remove SentryDependencyContainer uses in SentryCrash
#7514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
811ed51
10c5625
19fc5ab
2065270
2bf41d4
ad95b86
8356b89
a0ba83e
02debdd
22d7fd2
f06b523
708b69a
55434e2
5d6fb07
48f185b
7bee0d1
d74a3f2
d658ec1
4e63349
51aa2e7
11bea7e
bb18a7f
eef3e2b
5c86043
96df891
cf45971
9cd8332
d59ab2a
599ee7b
4090604
b3301dc
648f2a2
5455e0f
039641b
4abc6c5
81c5db6
16cc298
806596e
a7bbc9c
f97754b
cbb6d35
04d2f72
df19413
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,9 @@ | |
| /** The exception handler that was in place before we installed ours. */ | ||
| static NSUncaughtExceptionHandler *g_previousUncaughtExceptionHandler; | ||
|
|
||
| /** Bridge for accessing SDK services. */ | ||
| static SentryCrashBridge *g_bridge = nil; | ||
|
|
||
| // ============================================================================ | ||
| #pragma mark - Callbacks - | ||
| // ============================================================================ | ||
|
|
@@ -113,6 +116,12 @@ | |
| #pragma mark - API - | ||
| // ============================================================================ | ||
|
|
||
| void | ||
| sentrycrashcm_nsexception_setBridge(SentryCrashBridge *bridge) | ||
| { | ||
| g_bridge = bridge; | ||
| } | ||
|
|
||
| static void | ||
| setEnabled(bool isEnabled) | ||
| { | ||
|
|
@@ -124,8 +133,7 @@ | |
|
|
||
| SENTRY_LOG_DEBUG(@"Setting new handler."); | ||
| NSSetUncaughtExceptionHandler(&handleUncaughtException); | ||
| SentryDependencyContainer.sharedInstance.crashReporter.uncaughtExceptionHandler | ||
| = &handleUncaughtException; | ||
| g_bridge.crashReporter.uncaughtExceptionHandler = &handleUncaughtException; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nil bridge silently skips uncaught exception handler registrationHigh Severity If |
||
| } else { | ||
| SENTRY_LOG_DEBUG(@"Restoring original handler."); | ||
| NSSetUncaughtExceptionHandler(g_previousUncaughtExceptionHandler); | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.