feat(network-details): Introduce data classes for extracting network details to session replay#7582
feat(network-details): Introduce data classes for extracting network details to session replay#758243jay wants to merge 1 commit intomobile-935/ios-swift-appfrom
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mobile-935/ios-swift-app #7582 +/- ##
============================================================
Coverage ? 84.957%
============================================================
Files ? 486
Lines ? 28872
Branches ? 12546
============================================================
Hits ? 24529
Misses ? 4295
Partials ? 48
Continue to review full report in Codecov by Sentry.
|
71fd40b to
78d1d60
Compare
0898913 to
240ba73
Compare
78d1d60 to
9a4f8b3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
9a4f8b3 to
c62d15c
Compare
Add SentryReplayNetworkDetails — a single Swift class that encapsulates network request/response data for session replay breadcrumbs. Exposes minimal @objc surface (init, setRequest, setResponse) for ObjC callers (SentryNetworkTracker), with idiomatic Swift internals: nested Body, Detail, and BodyContent types, plus a NetworkBodyWarning enum.
c62d15c to
e717c1a
Compare
| import Foundation | ||
|
|
||
| /// Warning codes for network body capture issues. | ||
| enum NetworkBodyWarning: String { |
There was a problem hiding this comment.
m: Are these strings defined anywhere?
If they, can you add a link to the doc for future references?
📜 Description
Class diagram
Expected usage
💡 Motivation and Context
See corresponding class definitions in sentry-java
This PR only defines the data contract used by PRs higher in the stack.
See first PR for more motivation/context.
💚 How did you test it?
Unit tests are in the next PR in the stack, which introduces the body parsing and header extraction logic that operates on these types.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled. requires opt-in via specifying networkDetailAllowUrlsCloses #7623