docs: Add teardown best practice to TEST.md#7677
Merged
Conversation
Recommend addTeardownBlock over global tearDown() to scope cleanup to only the tests that need it. Agent transcript: https://claudescope.sentry.dev/share/VzllIibFqOj9XUWSxgWwwovi7XfbHAX1Hj8jmY0tQTo
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
philipphofmann
added
the
ready-to-merge
itaybre
reviewed
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addTeardownBlockover globaltearDown()to scope cleanup to only the tests that need it#skip-changelog