test: Improve SentryHttpStatusCodeRange tests#7678
Merged
philipphofmann merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
Add property verification, boundary, and edge case coverage for both initializers and isInRange. Adopt consistent naming convention. Agent transcript: https://claudescope.sentry.dev/share/YUPkoCiAV9s9UjZNW-4gf7hvftpvcCTL6bhgviKQb8U
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7678 +/- ##
=============================================
+ Coverage 85.307% 85.896% +0.589%
=============================================
Files 485 485
Lines 28837 28837
Branches 12521 12526 +5
=============================================
+ Hits 24600 24770 +170
+ Misses 4190 4019 -171
- Partials 47 48 +1 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initWithMin:max:andinitWithStatusCode:to catch assignment bugs thatisInRangealone might missmin == max, inverted range) to cover conditional branches not exercised by the original mid-range and far-away valuestest<Function>_when<Condition>_should<Expected>naming convention for self-documenting test names#skip-changelog
Closes #7679