Skip to content

Commit 6ba27ad

Browse files
Lms24lcian
Lms24
and
lcian
authored
fix(http): Change data type of request timing spans to double (#134)
Co-authored-by: Lorenzo Cian <[email protected]>
1 parent 5d07961 commit 6ba27ad

14 files changed

+56
-56
lines changed

‎generated/attributes/http.md‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -82,54 +82,54 @@ The UNIX timestamp representing the time immediately before the user agent start
8282

8383
| Property | Value |
8484
| --- | --- |
85-
| Type | `integer` |
85+
| Type | `double` |
8686
| Has PII | false |
8787
| Exists in OpenTelemetry | No |
88-
| Example | `1732829555` |
88+
| Example | `1732829555.111` |
8989

9090
### http.request.connection_end
9191

9292
The UNIX timestamp representing the time immediately after the browser finishes establishing the connection to the server to retrieve the resource. The timestamp value includes the time interval to establish the transport connection, as well as other time intervals such as TLS handshake and SOCKS authentication.
9393

9494
| Property | Value |
9595
| --- | --- |
96-
| Type | `integer` |
96+
| Type | `double` |
9797
| Has PII | false |
9898
| Exists in OpenTelemetry | No |
99-
| Example | `1732829555` |
99+
| Example | `1732829555.15` |
100100

101101
### http.request.domain_lookup_end
102102

103103
The UNIX timestamp representing the time immediately after the browser finishes the domain-name lookup for the resource.
104104

105105
| Property | Value |
106106
| --- | --- |
107-
| Type | `integer` |
107+
| Type | `double` |
108108
| Has PII | false |
109109
| Exists in OpenTelemetry | No |
110-
| Example | `1732829555` |
110+
| Example | `1732829555.201` |
111111

112112
### http.request.domain_lookup_start
113113

114114
The UNIX timestamp representing the time immediately before the browser starts the domain name lookup for the resource.
115115

116116
| Property | Value |
117117
| --- | --- |
118-
| Type | `integer` |
118+
| Type | `double` |
119119
| Has PII | false |
120120
| Exists in OpenTelemetry | No |
121-
| Example | `1732829555` |
121+
| Example | `1732829555.322` |
122122

123123
### http.request.fetch_start
124124

125125
The UNIX timestamp representing the time immediately before the browser starts to fetch the resource.
126126

127127
| Property | Value |
128128
| --- | --- |
129-
| Type | `integer` |
129+
| Type | `double` |
130130
| Has PII | false |
131131
| Exists in OpenTelemetry | No |
132-
| Example | `1732829555` |
132+
| Example | `1732829555.389` |
133133

134134
### http.request.header.\<key\>
135135

@@ -164,29 +164,29 @@ The UNIX timestamp representing the timestamp immediately after receiving the la
164164
| Type | `double` |
165165
| Has PII | false |
166166
| Exists in OpenTelemetry | No |
167-
| Example | `1732829558` |
167+
| Example | `1732829558.502` |
168168

169169
### http.request.redirect_start
170170

171171
The UNIX timestamp representing the start time of the fetch which that initiates the redirect.
172172

173173
| Property | Value |
174174
| --- | --- |
175-
| Type | `integer` |
175+
| Type | `double` |
176176
| Has PII | false |
177177
| Exists in OpenTelemetry | No |
178-
| Example | `1732829555` |
178+
| Example | `1732829555.495` |
179179

180180
### http.request.request_start
181181

182182
The UNIX timestamp representing the time immediately before the browser starts requesting the resource from the server, cache, or local resource. If the transport connection fails and the browser retires the request, the value returned will be the start of the retry request.
183183

184184
| Property | Value |
185185
| --- | --- |
186-
| Type | `integer` |
186+
| Type | `double` |
187187
| Has PII | false |
188188
| Exists in OpenTelemetry | No |
189-
| Example | `1732829555` |
189+
| Example | `1732829555.51` |
190190

191191
### http.request.resend_count
192192

@@ -205,32 +205,32 @@ The UNIX timestamp representing the time immediately after the browser receives
205205

206206
| Property | Value |
207207
| --- | --- |
208-
| Type | `integer` |
208+
| Type | `double` |
209209
| Has PII | false |
210210
| Exists in OpenTelemetry | No |
211-
| Example | `1732829555` |
211+
| Example | `1732829555.89` |
212212

213213
### http.request.response_start
214214

215215
The UNIX timestamp representing the time immediately before the browser starts requesting the resource from the server, cache, or local resource. If the transport connection fails and the browser retires the request, the value returned will be the start of the retry request.
216216

217217
| Property | Value |
218218
| --- | --- |
219-
| Type | `integer` |
219+
| Type | `double` |
220220
| Has PII | false |
221221
| Exists in OpenTelemetry | No |
222-
| Example | `1732829555` |
222+
| Example | `1732829555.7` |
223223

224224
### http.request.secure_connection_start
225225

226226
The UNIX timestamp representing the time immediately before the browser starts the handshake process to secure the current connection. If a secure connection is not used, the property returns zero.
227227

228228
| Property | Value |
229229
| --- | --- |
230-
| Type | `integer` |
230+
| Type | `double` |
231231
| Has PII | false |
232232
| Exists in OpenTelemetry | No |
233-
| Example | `1732829555` |
233+
| Example | `1732829555.73` |
234234

235235
### http.request.worker_start
236236

@@ -241,7 +241,7 @@ The UNIX timestamp representing the timestamp immediately before dispatching the
241241
| Type | `double` |
242242
| Has PII | false |
243243
| Exists in OpenTelemetry | No |
244-
| Example | `1732829553` |
244+
| Example | `1732829553.68` |
245245

246246
### http.response.body.size
247247

‎javascript/sentry-conventions/src/attributes.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3130,7 +3130,7 @@ export type HTTP_QUERY_TYPE = string;
31303130
*
31313131
* Attribute defined in OTEL: No
31323132
*
3133-
* @example 1732829555
3133+
* @example 1732829555.111
31343134
*/
31353135
export const HTTP_REQUEST_CONNECT_START = 'http.request.connect_start';
31363136

@@ -3150,7 +3150,7 @@ export type HTTP_REQUEST_CONNECT_START_TYPE = number;
31503150
*
31513151
* Attribute defined in OTEL: No
31523152
*
3153-
* @example 1732829555
3153+
* @example 1732829555.15
31543154
*/
31553155
export const HTTP_REQUEST_CONNECTION_END = 'http.request.connection_end';
31563156

@@ -3170,7 +3170,7 @@ export type HTTP_REQUEST_CONNECTION_END_TYPE = number;
31703170
*
31713171
* Attribute defined in OTEL: No
31723172
*
3173-
* @example 1732829555
3173+
* @example 1732829555.201
31743174
*/
31753175
export const HTTP_REQUEST_DOMAIN_LOOKUP_END = 'http.request.domain_lookup_end';
31763176

@@ -3190,7 +3190,7 @@ export type HTTP_REQUEST_DOMAIN_LOOKUP_END_TYPE = number;
31903190
*
31913191
* Attribute defined in OTEL: No
31923192
*
3193-
* @example 1732829555
3193+
* @example 1732829555.322
31943194
*/
31953195
export const HTTP_REQUEST_DOMAIN_LOOKUP_START = 'http.request.domain_lookup_start';
31963196

@@ -3210,7 +3210,7 @@ export type HTTP_REQUEST_DOMAIN_LOOKUP_START_TYPE = number;
32103210
*
32113211
* Attribute defined in OTEL: No
32123212
*
3213-
* @example 1732829555
3213+
* @example 1732829555.389
32143214
*/
32153215
export const HTTP_REQUEST_FETCH_START = 'http.request.fetch_start';
32163216

@@ -3274,7 +3274,7 @@ export type HTTP_REQUEST_METHOD_TYPE = string;
32743274
*
32753275
* Attribute defined in OTEL: No
32763276
*
3277-
* @example 1732829558
3277+
* @example 1732829558.502
32783278
*/
32793279
export const HTTP_REQUEST_REDIRECT_END = 'http.request.redirect_end';
32803280

@@ -3294,7 +3294,7 @@ export type HTTP_REQUEST_REDIRECT_END_TYPE = number;
32943294
*
32953295
* Attribute defined in OTEL: No
32963296
*
3297-
* @example 1732829555
3297+
* @example 1732829555.495
32983298
*/
32993299
export const HTTP_REQUEST_REDIRECT_START = 'http.request.redirect_start';
33003300

@@ -3314,7 +3314,7 @@ export type HTTP_REQUEST_REDIRECT_START_TYPE = number;
33143314
*
33153315
* Attribute defined in OTEL: No
33163316
*
3317-
* @example 1732829555
3317+
* @example 1732829555.51
33183318
*/
33193319
export const HTTP_REQUEST_REQUEST_START = 'http.request.request_start';
33203320

@@ -3354,7 +3354,7 @@ export type HTTP_REQUEST_RESEND_COUNT_TYPE = number;
33543354
*
33553355
* Attribute defined in OTEL: No
33563356
*
3357-
* @example 1732829555
3357+
* @example 1732829555.89
33583358
*/
33593359
export const HTTP_REQUEST_RESPONSE_END = 'http.request.response_end';
33603360

@@ -3374,7 +3374,7 @@ export type HTTP_REQUEST_RESPONSE_END_TYPE = number;
33743374
*
33753375
* Attribute defined in OTEL: No
33763376
*
3377-
* @example 1732829555
3377+
* @example 1732829555.7
33783378
*/
33793379
export const HTTP_REQUEST_RESPONSE_START = 'http.request.response_start';
33803380

@@ -3394,7 +3394,7 @@ export type HTTP_REQUEST_RESPONSE_START_TYPE = number;
33943394
*
33953395
* Attribute defined in OTEL: No
33963396
*
3397-
* @example 1732829555
3397+
* @example 1732829555.73
33983398
*/
33993399
export const HTTP_REQUEST_SECURE_CONNECTION_START = 'http.request.secure_connection_start';
34003400

@@ -3414,7 +3414,7 @@ export type HTTP_REQUEST_SECURE_CONNECTION_START_TYPE = number;
34143414
*
34153415
* Attribute defined in OTEL: No
34163416
*
3417-
* @example 1732829553
3417+
* @example 1732829553.68
34183418
*/
34193419
export const HTTP_REQUEST_WORKER_START = 'http.request.worker_start';
34203420

‎model/attributes/http/http__request__connect_start.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.connect_start",
33
"brief": "The UNIX timestamp representing the time immediately before the user agent starts establishing the connection to the server to retrieve the resource.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.111,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__connection_end.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.connection_end",
33
"brief": "The UNIX timestamp representing the time immediately after the browser finishes establishing the connection to the server to retrieve the resource. The timestamp value includes the time interval to establish the transport connection, as well as other time intervals such as TLS handshake and SOCKS authentication.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.15,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__domain_lookup_end.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.domain_lookup_end",
33
"brief": "The UNIX timestamp representing the time immediately after the browser finishes the domain-name lookup for the resource.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.201,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__domain_lookup_start.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.domain_lookup_start",
33
"brief": "The UNIX timestamp representing the time immediately before the browser starts the domain name lookup for the resource.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.322,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__fetch_start.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.fetch_start",
33
"brief": "The UNIX timestamp representing the time immediately before the browser starts to fetch the resource.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.389,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__redirect_end.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829558,
9+
"example": 1732829558.502,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__redirect_start.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.redirect_start",
33
"brief": "The UNIX timestamp representing the start time of the fetch which that initiates the redirect.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.495,
1010
"sdks": ["javascript-browser"]
1111
}

‎model/attributes/http/http__request__request_start.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"key": "http.request.request_start",
33
"brief": "The UNIX timestamp representing the time immediately before the browser starts requesting the resource from the server, cache, or local resource. If the transport connection fails and the browser retires the request, the value returned will be the start of the retry request.",
4-
"type": "integer",
4+
"type": "double",
55
"pii": {
66
"key": "false"
77
},
88
"is_in_otel": false,
9-
"example": 1732829555,
9+
"example": 1732829555.51,
1010
"sdks": ["javascript-browser"]
1111
}

0 commit comments

Comments
 (0)