Conversation
JPeer264
requested review from
a team,
Lms24,
cleptric,
lcian,
mjq and
nsdeschenes
as code owners
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
sentry-conventions | 61cbb66 | Feb 23 2026, 09:09 AM |
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/move-to-cloudflare
branch
from
1d163d2 to
61cbb66
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| export default defineConfig({ | ||
| integrations: [svelte(), tailwind()], | ||
| // Configure for GitHub Pages - the site will be at https://getsentry.github.io/sentry-conventions/ | ||
| site: 'https://getsentry.github.io', | ||
| base: '/sentry-conventions/', | ||
| output: 'static', | ||
| site: 'https://sentry-conventions.getsentry.workers.dev', | ||
| adapter: cloudflare({ | ||
| imageService: 'compile', | ||
| }), | ||
| }); |
There was a problem hiding this comment.
Bug: Removing output: 'static' switches the site to SSR mode, which breaks the pagefind search indexing step as it requires pre-rendered HTML files that are no longer generated.
Severity: HIGH
Suggested Fix
To fix this, either restore static site generation by re-adding output: 'static' to astro.config.mjs, or if SSR is intended, add export const prerender = true to all pages that need to be indexed by Pagefind. This will ensure the necessary HTML files are available during the build.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/astro.config.mjs#L8-L14
Potential issue: The Astro configuration was changed to use the Cloudflare adapter, and
`output: 'static'` was removed. This causes the site to default to server-side rendering
(SSR). The build process includes a `postbuild` step that runs `pagefind --site dist` to
generate a search index. Pagefind requires pre-rendered HTML files in the `dist/`
directory. In SSR mode without any `export const prerender = true` flags, the `dist/`
directory will contain a server worker bundle, not static HTML files. As a result,
Pagefind will have no content to index, causing the search feature to break or the build
to fail.
|
|
||
| ### Adding a new page |
There was a problem hiding this comment.
Bug: The README.md file contains hardcoded links to the old GitHub Pages deployment, which will be broken after the migration to Cloudflare Workers.
Severity: MEDIUM
Suggested Fix
Update the hardcoded links in docs/README.md to point to the new Cloudflare Workers URLs. For example, change https://getsentry.github.io/sentry-conventions/attributes/ to https://sentry-conventions.getsentry.workers.dev/attributes/.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/README.md#L68-L69
Potential issue: The root `README.md` file contains hardcoded links pointing to the old
GitHub Pages deployment (`https://getsentry.github.io/sentry-conventions/...`). With the
migration to Cloudflare Workers, the site's URL has changed and the
`/sentry-conventions/` base path has been removed. The old links will no longer be
valid, leading users who click them to a broken or non-existent page. This affects the
primary entry point for users trying to access the generated documentation from the
repository's main page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| site: 'https://sentry-conventions.getsentry.workers.dev', | ||
| adapter: cloudflare({ | ||
| imageService: 'compile', | ||
| }), |
There was a problem hiding this comment.
GitHub Pages workflow deploys broken site after config change
Medium Severity
The removal of base: '/sentry-conventions/' and change of site to the Cloudflare URL breaks the existing .github/workflows/docs.yml workflow, which still runs on every push to main and deploys to GitHub Pages. The built site will have all URLs relative to / instead of /sentry-conventions/, so the GitHub Pages deployment at getsentry.github.io/sentry-conventions/ will serve a completely broken site with missing assets and broken links. The old workflow needs to be removed or replaced with a Cloudflare deployment workflow.
|
Closed as won't do as discussed offline. The code is here in case we would need it in the future |
1 participant
Description
This moves everything from GH Pages to Cloudflare Workers (Sentry is not yet included).
Available here: https://sentry-conventions.getsentry.workers.dev/
Everything will be automatically deployed when it gets pushed to
mainPR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: