Open
Conversation
We currently have a definition for `resource.deployment.environment.name`, deprecated for `sentry.environment` with a `backfill` policy. That means that incoming spans using the OpenTelemetry conventional attribute `deployment.environment.name` in their span's `resource` will get the value copied to `sentry.environment` in Relay, which makes the environment filters work across the product. `deployment.environment.name` was introduced in OTel's semantic conventions v1.27.0 as a replacement for `deployment.environment`, which was deprecated at that time. One of our customers is still using this deprecated attribute, and I'm sure they're not alone in that. Define `resource.deployment.environment` as a deprecated, backfilled attribute so that clients using it, too will get working environment filters in the product.
mjq
requested review from
a team,
Lms24,
cleptric,
lcian and
nsdeschenes
as code owners
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently have a definition for
resource.deployment.environment.name, deprecated forsentry.environmentwith abackfillpolicy. That means that incoming spans using the OpenTelemetry conventional attributedeployment.environment.namein their span'sresourcewill get the value copied tosentry.environmentin Relay, which makes the environment filters work across the product. (see #196)deployment.environment.namewas introduced in OTel's semantic conventions v1.27.0 (Aug 2024) as a replacement fordeployment.environment, which was deprecated at that time. One of our customers is still using this deprecated attribute, and I'm sure they're not alone in that. Defineresource.deployment.environmentas a deprecated, backfilled attribute so that clients using it, too will get working environment filters in the product.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)falseto matchsentry.environment(presumably because the product depends on the exact given value)