Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/sentry-conventions/src/attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5119,7 +5119,7 @@ export type SENTRY_OP_TYPE = string;
// Path: model/attributes/sentry/sentry__origin.json

/**
* The origin of a span. `sentry.origin`
* The origin of the instrumentation (e.g. span, log, etc.). `sentry.origin`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it can now be used outside of the context of a span.

*
* Attribute Value Type: `string` {@link SENTRY_ORIGIN_TYPE}
*
Expand Down
10 changes: 10 additions & 0 deletions model/attributes/browser/browser__report__type.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, you can experiment with the fields in here.

You can also refer to this w3c document.

"key": "browser.report.type",
"brief": "A browser report sent via reporting API..",
"type": "string",
"pii": {
"key": "false"
},
"is_in_otel": false,
"example": "network-error"
}
8 changes: 8 additions & 0 deletions model/attributes/nel/nel__elapsed_time.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"key": "nel.elapsed_time",
"brief": "The elapsed number of milliseconds between the start of the resource fetch and when it was completed or aborted by the user agent.",
"type": "number",
"pii": { "key": "false" },
"is_in_otel": false,
"example": 100
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For numeric examples, I assume I can put it without quotes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this is valid. The tests should catch this.

}
8 changes: 8 additions & 0 deletions model/attributes/nel/nel__phase.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"key": "nel.phase",
"brief": "If request failed, the phase of its network error. If request succeeded, \"application\".",
"type": "string",
"pii": { "key": "false" },
"is_in_otel": false,
"example": "application"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. dns, application , connection

}
8 changes: 8 additions & 0 deletions model/attributes/nel/nel__referrer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"key": "nel.referrer",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional double rr 😄

"brief": "request's referrer, as determined by the referrer policy associated with its client.",
"type": "string",
"pii": { "key": "false" },
"is_in_otel": false,
"example": "https://example.com/foo?bar=baz"
}
8 changes: 8 additions & 0 deletions model/attributes/nel/nel__sampling_function.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"key": "nel.sampling_function",
"brief": "The sampling function used to determine if the request should be sampled.",
"type": "float",
"pii": { "key": "false" },
"is_in_otel": false,
"example": 0.5
}
8 changes: 8 additions & 0 deletions model/attributes/nel/nel__type.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"key": "nel.type",
"brief": "If request failed, the type of its network error. If request succeeded, \"ok\".",
"type": "string",
"pii": { "key": "false" },
"is_in_otel": false,
"example": "dns.unreachable"
}
2 changes: 1 addition & 1 deletion model/attributes/sentry/sentry__origin.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"key": "sentry.origin",
"brief": "The origin of a span.",
"brief": "The origin of the instrumentation (e.g. span, log, etc.)",
"type": "string",
"pii": {
"key": "false"
Expand Down
Loading