-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add NEL-related attributes #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d035ae
Add NEL-related attributes
armenzg 15567b0
Fix linting issues
armenzg 5df9ea8
Switch to integer
armenzg b6aa7fe
Fix double
armenzg b9ba4f3
Generate
armenzg 8876bd9
Fix
armenzg 7b5bbee
Merge branch 'main' into browser/reports/nel/armenzg
armenzg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| <!-- THIS FILE IS AUTO-GENERATED. DO NOT EDIT DIRECTLY. --> | ||
|
|
||
| # Nel Attributes | ||
|
|
||
| - [Stable Attributes](#stable-attributes) | ||
| - [nel.elapsed_time](#nelelapsed_time) | ||
| - [nel.phase](#nelphase) | ||
| - [nel.referrer](#nelreferrer) | ||
| - [nel.sampling_function](#nelsampling_function) | ||
| - [nel.type](#neltype) | ||
|
|
||
| ## Stable Attributes | ||
|
|
||
| ### nel.elapsed_time | ||
|
|
||
| The elapsed number of milliseconds between the start of the resource fetch and when it was completed or aborted by the user agent. | ||
|
|
||
| | Property | Value | | ||
| | --- | --- | | ||
| | Type | `integer` | | ||
| | Has PII | false | | ||
| | Exists in OpenTelemetry | No | | ||
| | Example | `100` | | ||
|
|
||
| ### nel.phase | ||
|
|
||
| If request failed, the phase of its network error. If request succeeded, "application". | ||
|
|
||
| | Property | Value | | ||
| | --- | --- | | ||
| | Type | `string` | | ||
| | Has PII | false | | ||
| | Exists in OpenTelemetry | No | | ||
| | Example | `application` | | ||
|
|
||
| ### nel.referrer | ||
|
|
||
| request's referrer, as determined by the referrer policy associated with its client. | ||
|
|
||
| | Property | Value | | ||
| | --- | --- | | ||
| | Type | `string` | | ||
| | Has PII | false | | ||
| | Exists in OpenTelemetry | No | | ||
| | Example | `https://example.com/foo?bar=baz` | | ||
|
|
||
| ### nel.sampling_function | ||
|
|
||
| The sampling function used to determine if the request should be sampled. | ||
|
|
||
| | Property | Value | | ||
| | --- | --- | | ||
| | Type | `double` | | ||
| | Has PII | false | | ||
| | Exists in OpenTelemetry | No | | ||
| | Example | `0.5` | | ||
|
|
||
| ### nel.type | ||
|
|
||
| If request failed, the type of its network error. If request succeeded, "ok". | ||
|
|
||
| | Property | Value | | ||
| | --- | --- | | ||
| | Type | `string` | | ||
| | Has PII | false | | ||
| | Exists in OpenTelemetry | No | | ||
| | Example | `dns.unreachable` | | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "key": "browser.report.type", | ||
| "brief": "A browser report sent via reporting API..", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "false" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "network-error" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "key": "nel.elapsed_time", | ||
| "brief": "The elapsed number of milliseconds between the start of the resource fetch and when it was completed or aborted by the user agent.", | ||
| "type": "integer", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": 100 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "key": "nel.phase", | ||
| "brief": "If request failed, the phase of its network error. If request succeeded, \"application\".", | ||
| "type": "string", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": "application" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "key": "nel.referrer", | ||
| "brief": "request's referrer, as determined by the referrer policy associated with its client.", | ||
| "type": "string", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": "https://example.com/foo?bar=baz" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "key": "nel.sampling_function", | ||
| "brief": "The sampling function used to determine if the request should be sampled.", | ||
| "type": "double", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": 0.5 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "key": "nel.type", | ||
| "brief": "If request failed, the type of its network error. If request succeeded, \"ok\".", | ||
| "type": "string", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": "dns.unreachable" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, you can experiment with the fields in here.
You can also refer to this w3c document.