Skip to content

Conversation

@MaximBelov
Copy link

No description provided.

@lucas-zimerman
Copy link
Collaborator

Hi, and thanks so much for your PR!
Since this includes major changes, we’ll take some time to evaluate the best path forward.

Could you share what motivated you to bump the Android and JavaScript SDK versions?

Thanks again for your contribution!

@MaximBelov
Copy link
Author

Hi
Regarding the Android SDK:
Our project uses the Intercom SDK, which has a transitive dependency on Sentry:
https://repo1.maven.org/maven2/io/intercom/android/intercom-sdk-base/16.3.0/intercom-sdk-base-16.3.0.pom

Regarding the JavaScript SDK:
While updating this part is optional, we would like to use the latest version of the Sentry SDK if feasible.

@Virgile-R
Copy link

With the recent changes to Android regarding page sizes, upgrading the sentry-java SDK would allow Cordova apps using Sentry to adhere to this new standard, which are not passing with the current 1.7 version.

Using the Google provided check_elf script:
Version 1.7 with Sentry Android v7.22.6
image

modified version with Sentry Android v8.21.1
image

Is there more work to be done on this PR? We have experimented locally with similar changes and the plugin appears to work fine.

@markushi
Copy link
Member

@Virgile-R can you double check which version of the sentry SDK you're using?

Downloading 7.22.6 from our releases page and extracting the .aar shows that all files are aligned:

./check_elf_alignment.sh sentry-android-ndk-7.22.6

=== ELF alignment ===
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/armeabi-v7a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/armeabi-v7a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/x86/libsentry.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/x86/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/arm64-v8a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/arm64-v8a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/x86_64/libsentry.so: \e[32mALIGNED\e[0m (2**14)
sentry-android-ndk-7.22.6/sentry-android-ndk-release/jni/x86_64/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
=====================

@Virgile-R
Copy link

Thanks @markushi , we were indeed still on version 7.17. Building with version 7.22.6 shows the correct alignment.

All good.

@lucas-zimerman
Copy link
Collaborator

Thanks @markushi , we were indeed still on version 7.17. Building with version 7.22.6 shows the correct alignment.

All good.

glad to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants