-
-
Notifications
You must be signed in to change notification settings - Fork 269
Log a warning when dropping envelope items #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Log a warning when dropping envelope items ([#3165](https://github.com/getsentry/sentry-dart/pull/3165)) If none of the above apply, you can opt out of this check by adding |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
+ Coverage 87.79% 87.81% +0.02%
==========================================
Files 291 291
Lines 9888 9891 +3
==========================================
+ Hits 8681 8686 +5
+ Misses 1207 1205 -2 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
6f47800 | 451.04 ms | 509.64 ms | 58.60 ms |
79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
cc4e375 | 426.15 ms | 482.34 ms | 56.19 ms |
f761369 | 462.73 ms | 563.80 ms | 101.06 ms |
de377fd | 572.35 ms | 589.21 ms | 16.87 ms |
6b69699 | 456.06 ms | 557.44 ms | 101.38 ms |
0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
6f47800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
cc4e375 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
f761369 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
de377fd | 6.54 MiB | 7.71 MiB | 1.17 MiB |
6b69699 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2cb90b9 | 1272.90 ms | 1285.55 ms | 12.66 ms |
dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
81f83eb | 1259.53 ms | 1273.39 ms | 13.86 ms |
793f4dc | 1262.50 ms | 1282.35 ms | 19.85 ms |
93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
4481076 | 1256.48 ms | 1266.64 ms | 10.17 ms |
cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2cb90b9 | 7.86 MiB | 9.54 MiB | 1.69 MiB |
dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
81f83eb | 7.86 MiB | 9.44 MiB | 1.58 MiB |
793f4dc | 7.86 MiB | 9.44 MiB | 1.58 MiB |
93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
4481076 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
📜 Description
Log a warning when dropping envelope items
💡 Motivation and Context
Closes #2436
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps