Add React Native V6 Changes #11320

krystofwoldrich · 2024-09-10T18:20:45Z

DESCRIBE YOUR PR

Sentry React Native V6 changes.

Migration guide will be in separate PR.

V6 Release sentry-react-native#3851

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

Urgent deadline (GA date, etc.):
Other deadline: The week of 30 September the RN v6 stable version will be published
None: Not urgent, can wait up to 1 week+

vercel · 2024-09-10T18:20:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
changelog	🛑 Canceled (Inspect)			Oct 14, 2024 11:09am
sentry-docs	🛑 Canceled (Inspect)			Oct 14, 2024 11:09am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
develop-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 14, 2024 11:09am

codecov · 2024-09-11T15:13:22Z

Bundle Report

Changes will increase total bundle size by 49.45kB (0.35%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sentry-docs-server	7.5MB	49.46kB (0.66%) ⬆️
sentry-docs-edge-server	254.43kB	3 bytes (-0.0%) ⬇️
sentry-docs-client	6.38MB	6 bytes (-0.0%) ⬇️

lizokm

Phew, what a PR!! I've made some language suggestions, but overall this looks really good.

docs/platforms/react-native/enriching-events/scopes/index.mdx

docs/platforms/react-native/tracing/instrumentation/expo-router.mdx

docs/platforms/react-native/tracing/instrumentation/react-native-navigation.mdx

docs/platforms/react-native/tracing/instrumentation/react-navigation.mdx

getsantry · 2024-10-08T07:00:27Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Co-authored-by: Liza Mock <[email protected]>

krystofwoldrich · 2024-10-08T16:38:29Z

@lizokm Thank you!

docs/platforms/react-native/tracing/instrumentation/expo-router.mdx

docs/platforms/react-native/integrations/default.mdx

lucas-zimerman

Left some comments on the code snippets that would be nice to be addressed, but other than that the PR looks good to me !

docs/platforms/react-native/enriching-events/scopes/index.mdx

docs/platforms/react-native/integrations/custom.mdx

…r.mdx Co-authored-by: LucasZF <[email protected]>

Co-authored-by: LucasZF <[email protected]>

Co-authored-by: Antonis Lilis <[email protected]>

krystofwoldrich · 2024-10-14T10:40:32Z

Thank you @lucas-zimerman and @antonis, I've applied the changes.

antonis

LGTM 🎉

lucas-zimerman

LGTM!

Add React Native V6 Changes

85c1559

More of new interfaces

34bc100

vercel bot deployed to Preview – changelog September 11, 2024 15:11 View deployment

krystofwoldrich mentioned this pull request Sep 11, 2024

V6 Release getsentry/sentry-react-native#3851

Merged

vercel bot deployed to Preview – sentry-docs September 11, 2024 15:24 View deployment

krystofwoldrich requested review from kahest, lizokm and lucas-zimerman September 12, 2024 07:33

krystofwoldrich marked this pull request as ready for review September 12, 2024 07:35

lizokm approved these changes Sep 16, 2024

View reviewed changes

getsantry bot added the Stale label Oct 8, 2024

krystofwoldrich removed the Stale label Oct 8, 2024

Apply suggestions from code review - new scopes

54cefc5

Co-authored-by: Liza Mock <[email protected]>

vercel bot had a problem deploying to Preview – changelog October 8, 2024 16:13 Failure

Apply suggestions from code review - integrations

124950a

Co-authored-by: Liza Mock <[email protected]>

vercel bot had a problem deploying to Preview – changelog October 8, 2024 16:24 Failure

krystofwoldrich and others added 3 commits October 8, 2024 18:28

Apply suggestions from code review

8e59c7c

Co-authored-by: Liza Mock <[email protected]>

Apply suggestions from code review

78af134

Co-authored-by: Liza Mock <[email protected]>

Apply suggestions from code review

56eb851

Co-authored-by: Liza Mock <[email protected]>

vercel bot had a problem deploying to Preview – changelog October 8, 2024 16:45 Failure

vercel bot deployed to Preview – sentry-docs October 8, 2024 16:59 View deployment

krystofwoldrich requested a review from antonis October 11, 2024 12:47

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

docs/platforms/react-native/tracing/instrumentation/expo-router.mdx Outdated Show resolved Hide resolved

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

docs/platforms/react-native/integrations/default.mdx Outdated Show resolved Hide resolved

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

docs/platforms/react-native/integrations/default.mdx Show resolved Hide resolved

lucas-zimerman requested changes Oct 11, 2024

View reviewed changes

antonis reviewed Oct 14, 2024

View reviewed changes

docs/platforms/react-native/enriching-events/scopes/index.mdx Outdated Show resolved Hide resolved

antonis reviewed Oct 14, 2024

View reviewed changes

docs/platforms/react-native/integrations/custom.mdx Outdated Show resolved Hide resolved

krystofwoldrich and others added 5 commits October 14, 2024 12:38

Update docs/platforms/react-native/tracing/instrumentation/expo-route…

b5d5ccf

…r.mdx Co-authored-by: LucasZF <[email protected]>

Update docs/platforms/react-native/integrations/default.mdx

8c7216a

Co-authored-by: LucasZF <[email protected]>

Update docs/platforms/react-native/integrations/default.mdx

019fe3b

Co-authored-by: LucasZF <[email protected]>

Update docs/platforms/react-native/enriching-events/scopes/index.mdx

8fb28e1

Co-authored-by: Antonis Lilis <[email protected]>

Update docs/platforms/react-native/integrations/custom.mdx

0a62f1d

Co-authored-by: Antonis Lilis <[email protected]>

vercel bot had a problem deploying to Preview – changelog October 14, 2024 10:43 Failure

antonis approved these changes Oct 14, 2024

View reviewed changes

vercel bot deployed to Preview – sentry-docs October 14, 2024 11:09 View deployment

lucas-zimerman approved these changes Oct 14, 2024

View reviewed changes

krystofwoldrich mentioned this pull request Oct 15, 2024

Sentry React Native V6 getsentry/sentry-react-native#3728

Closed

krystofwoldrich merged commit 5873e41 into master Oct 16, 2024
10 of 11 checks passed

krystofwoldrich deleted the kw/add-react-native-v6 branch October 16, 2024 08:42

krystofwoldrich mentioned this pull request Oct 16, 2024

fix(rn): tracePropagationTargets differs on mobile and web in RN v6 #11579

Merged

6 tasks

github-actions bot locked and limited conversation to collaborators Nov 1, 2024

Uh oh!

Add React Native V6 Changes #11320

Add React Native V6 Changes #11320

Uh oh!

Conversation

krystofwoldrich commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DESCRIBE YOUR PR

IS YOUR CHANGE URGENT?

Uh oh!

vercel bot commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

lizokm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

getsantry bot commented Oct 8, 2024

Uh oh!

krystofwoldrich commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich commented Oct 14, 2024

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

krystofwoldrich commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading