feat(apple): Replay Redact #11418

brustolin · 2024-09-23T14:47:21Z

Adding instructions on how to use custom redact APIs for Apple SDK.

vercel · 2024-09-23T14:47:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
changelog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 8, 2024 6:29am
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 8, 2024 6:29am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
develop-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 8, 2024 6:29am

JoshuaMoelans

Looks good! Just have some minor nitpicks on grammar & small question about using ignoreView without disabling the default

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

codecov · 2024-09-26T08:30:45Z

Bundle Report

Changes will increase total bundle size by 14.09MB (99.77%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
sentry-docs-server*	7.46MB	7.46MB (100%) ⬆️⚠️
sentry-docs-edge-server*	254.44kB	254.44kB (100%) ⬆️⚠️
sentry-docs-client*	6.38MB	6.38MB (100%) ⬆️⚠️
sentry-docs-server-cjs	7.45MB	224 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push	257.07kB	3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push	6.42MB	6 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

chargome · 2024-09-26T09:15:50Z

@brustolin please rebase this on master, then the pr should be un-blocked!

lizokm

Thanks for adding this! I left a few edits, but overall it looks great.

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

docs/platforms/apple/guides/ios/session-replay/index.mdx

philipphofmann

I think we need to explain the difference between redact and ignore, cause I don't get it 😅

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

philipphofmann · 2024-09-27T06:42:09Z

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

+
+## Redact by View class
+
+You can choose which type of view you want to redact or ignore by using the `redactViewClasses` or `ignoreViewClasses` options.


h: After reading this and the whole document, I'm still unsure of the difference between redact and ignore. Can we add a short explanation, please?

The document was updated. Please take another look

Co-authored-by: Liza Mock <[email protected]>

romtsn · 2024-10-02T12:15:59Z

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

@@ -0,0 +1,66 @@
+---
+title: Using Custom Redact for Session Replay


Should we name it Privacy similar to the JS sdk? https://docs.sentry.io/platforms/javascript/session-replay/privacy

I dont know, should we?

I would also add here the resume/pause functionality, and I think in this case it'd make sense to rename it as it's not only custom redaction/masking anymore. Maybe Privacy Controls or something like that would do?

Good point. I will improve in another doc. This is waiting for too long

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

philipphofmann

It's clearer to me now. LGTM

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

bruno-garcia

one note but LGTM

bruno-garcia · 2024-10-07T15:05:13Z

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

+
+<Alert>
+
+If you choose to use custom masking in your Session Replays, you may accidentally expose sensitive customer data. Be sure to double-check what you choose to expose.


That's because for that they must disable the default masking, right?
Worth calling that out?

@lizokm might have ideas?

This is just an extra reminder, so the user understands the severity of it.

bruno-garcia · 2024-10-07T15:09:57Z

Lets add the min version need for this. We can remove later when we GA the whole thing and remove the .experimental property. Mention the final version with the non beta support

docs/platforms/apple/guides/ios/session-replay/customredact.mdx

Co-authored-by: Philipp Hofmann <[email protected]>

feat(apple): Replay Redact

c11fcc7

vercel bot deployed to Preview – changelog September 23, 2024 14:48 View deployment

brustolin linked an issue Sep 23, 2024 that may be closed by this pull request

FAQ for SwiftUI Replay Redaction #11374

Closed

vercel bot deployed to Preview – sentry-docs September 23, 2024 15:04 View deployment

brustolin marked this pull request as ready for review September 24, 2024 08:33

brustolin requested review from bruno-garcia and romtsn September 24, 2024 08:33

Update index.mdx

b2c94ff

vercel bot deployed to Preview – changelog September 24, 2024 08:38 View deployment

Update customredact.mdx

059f1ee

vercel bot deployed to Preview – changelog September 24, 2024 08:44 View deployment

vercel bot deployed to Preview – sentry-docs September 24, 2024 09:09 View deployment

brustolin requested review from kahest and philipphofmann September 25, 2024 06:16

JoshuaMoelans reviewed Sep 25, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

Apply suggestions from code review

461ee72

vercel bot had a problem deploying to Preview – changelog September 26, 2024 08:28 Failure

vercel bot deployed to Preview – sentry-docs September 26, 2024 08:42 View deployment

Merge branch 'master' into feat(apple)/redact-docs

dd5d568

vercel bot deployed to Preview – changelog September 26, 2024 11:37 View deployment

vercel bot deployed to Preview – develop-docs September 26, 2024 11:42 View deployment

vercel bot deployed to Preview – sentry-docs September 26, 2024 11:51 View deployment

lizokm approved these changes Sep 26, 2024

View reviewed changes

philipphofmann reviewed Sep 27, 2024

View reviewed changes

Apply suggestions from code review

f9b2d64

Co-authored-by: Liza Mock <[email protected]>

vercel bot deployed to Preview – changelog September 27, 2024 08:14 View deployment

vercel bot deployed to Preview – sentry-docs September 27, 2024 08:27 View deployment

romtsn reviewed Oct 2, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

romtsn reviewed Oct 2, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

brustolin added 2 commits October 3, 2024 14:42

Merge branch 'master' into feat(apple)/redact-docs

2c9e40b

update

f08690d

vercel bot deployed to Preview – changelog October 4, 2024 07:31 View deployment

vercel bot deployed to Preview – sentry-docs October 4, 2024 07:44 View deployment

brustolin requested review from JoshuaMoelans, lizokm, philipphofmann and romtsn October 4, 2024 08:21

brustolin commented Oct 4, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

Update docs/platforms/apple/guides/ios/session-replay/customredact.mdx

f0819df

brustolin commented Oct 4, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

Update docs/platforms/apple/guides/ios/session-replay/customredact.mdx

48c12d2

vercel bot deployed to Preview – changelog October 4, 2024 08:28 View deployment

vercel bot deployed to Preview – sentry-docs October 4, 2024 08:57 View deployment

bruno-garcia requested a review from jas-kas October 4, 2024 15:03

philipphofmann approved these changes Oct 7, 2024

View reviewed changes

bruno-garcia approved these changes Oct 7, 2024

View reviewed changes

brustolin commented Oct 8, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Show resolved Hide resolved

brustolin commented Oct 8, 2024

View reviewed changes

docs/platforms/apple/guides/ios/session-replay/customredact.mdx Outdated Show resolved Hide resolved

Apply suggestions from code review

aaed0e7

Co-authored-by: Philipp Hofmann <[email protected]>

vercel bot deployed to Preview – changelog October 8, 2024 06:16 View deployment

vercel bot deployed to Preview – sentry-docs October 8, 2024 06:29 View deployment

brustolin merged commit a03716d into master Oct 14, 2024
6 checks passed

brustolin deleted the feat(apple)/redact-docs branch October 14, 2024 11:43

github-actions bot locked and limited conversation to collaborators Oct 30, 2024


		## Redact by View class

		You can choose which type of view you want to redact or ignore by using the `redactViewClasses` or `ignoreViewClasses` options.

		@@ -0,0 +1,66 @@
		---
		title: Using Custom Redact for Session Replay


		<Alert>

		If you choose to use custom masking in your Session Replays, you may accidentally expose sensitive customer data. Be sure to double-check what you choose to expose.

Uh oh!

feat(apple): Replay Redact #11418

feat(apple): Replay Redact #11418

Uh oh!

Conversation

brustolin commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaMoelans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

chargome commented Sep 26, 2024

Uh oh!

lizokm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bruno-garcia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bruno-garcia commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

brustolin commented Sep 23, 2024 •

edited

Loading

vercel bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading