Skip to content

Adds a note that source maps are not uploaded for debug mode in React Native / Expo #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Adds a note that source maps are not uploaded for debug mode in React Native / Expo #11478

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
487ab29
Adds a note that source maps are not uploaded for debug
antonis Oct 3, 2024
77ce956
Merge branch 'master' into antonis/expo-debug-source-maps
antonis Oct 7, 2024
6d154f7
Moves debug source maps notice to the correct section
antonis Oct 7, 2024
e339fd8
Adds a debug source maps notice on the main source maps page
antonis Oct 7, 2024
19ff468
Removes simulator builds from the note
antonis Oct 7, 2024
545f92d
Removes simulator build from the expo note
antonis Oct 7, 2024
dea687a
Update wording of source maps debug builds section
antonis Oct 8, 2024
0af1713
Update wording of debug note on expo section
antonis Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/platforms/react-native/sourcemaps/uploading/expo.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ npx sentry-expo-upload-sourcemaps dist

- `dist` is the default output directory of `eas update`.
- Uploaded source maps have no associated releases. This is expected as updates can apply to multiple releases.
- Uploading of source maps for debug or simulator builds is disabled.
Copy link
Contributor

@krystofwoldrich krystofwoldrich Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are notes for EAS Updates, meaning for situation when a user creates a JS bundle to distribute as ota update.

This note is relevant for the previous section [Automatic Upload for Release](https://docs.sentry.io/platforms/react-native/sourcemaps/uploading/expo/#automatic-upload-for-release)

I would also include one sentence why, we do not auto upload for Debug.

Copy link
Contributor Author

@antonis antonis Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @krystofwoldrich 🙇 I've moved the note to the correct section adding a short sentence for the why with 6d154f7.

I think we should include the information also on the main source maps page.

Also added a separate a bit more extended section on the main source maps page with e339fd8

Copy link
Contributor

@krystofwoldrich krystofwoldrich Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I suggest removing the sim builds as release for sim will upload the source maps.

I also added @lizokm to review the docs style.

Copy link
Contributor Author

@antonis antonis Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @krystofwoldrich! Makes sense. I've committed your suggestions 🙇


## Notes

Expand Down
Loading