Skip to content

Conversation

@bruno-garcia
Copy link
Member

onboarding is incorrectly dictating only Sentry.Profiling when the profiling checkbox is chcked. It should add it to the existing Sentry package.

@vercel
Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 3:58am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 3:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Oct 6, 2024 3:58am

{
options.Dsn = "https://[email protected]/5428537";
options.Debug = true;
options.AutoSessionTracking = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed this since it can't be added on a blank dotnet instruction. Otherwise this would be on by default.

On mobile for example it's already on by default. On aspnet it takes no effect since no server mode was added

@codecov
Copy link

codecov bot commented Oct 6, 2024

Bundle Report

Changes will increase total bundle size by 192.43kB (1.36%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.64MB 192.44kB (2.58%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

@bruno-garcia
Copy link
Member Author

image

Looks OK now.

Please just merge after (if) approving

@bruno-garcia bruno-garcia requested a review from lizokm October 6, 2024 04:02
@bitsandfoxes bitsandfoxes merged commit 67eb973 into master Oct 7, 2024
10 checks passed
@bitsandfoxes bitsandfoxes deleted the bruno-garcia-patch-1 branch October 7, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants