Skip to content

Conversation

@stayallive
Copy link
Collaborator

@stayallive stayallive commented Oct 7, 2024

DESCRIBE YOUR PR

Some automatic tracing features are only available when using a certain version of Laravel, that is now documented better. Also updated some links to packages that were outdated.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@stayallive stayallive requested a review from cleptric October 7, 2024 12:02
@stayallive stayallive self-assigned this Oct 7, 2024
@vercel
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:17am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Oct 7, 2024 0:17am

@codecov
Copy link

codecov bot commented Oct 7, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.45MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cleptric cleptric merged commit 5b3c804 into master Oct 7, 2024
10 checks passed
@cleptric cleptric deleted the feature/laravel-integration-versions branch October 7, 2024 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants