Skip to content

Conversation

@AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@AbhiPrasad AbhiPrasad requested a review from a team October 16, 2024 13:09
@AbhiPrasad AbhiPrasad self-assigned this Oct 16, 2024
@AbhiPrasad AbhiPrasad requested review from Lms24 and lforst and removed request for a team October 16, 2024 13:09
@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 7:09pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 7:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 7:09pm

@codecov
Copy link

codecov bot commented Oct 16, 2024

Bundle Report

Changes will increase total bundle size by 438 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.51MB 447 bytes (0.01%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a wild one but probably very useful

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! Left a couple of suggestions but looks good to me.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 6, 2024 18:51
@AbhiPrasad AbhiPrasad merged commit 18d7ba7 into master Nov 6, 2024
11 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-hydrogen-docs branch November 6, 2024 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants