Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Oct 17, 2024

Add a warning message for Angular as it can break customer sites (or lead to performance problems) when using the default change detection strategy due to their monkeypatching of globals (Zone.js)

…n Strategy

Add a warning message for Angular as it can break customer sites (or lead to performance problems) when using the default change detection strategy due to their monkeypatching of globals (Zone.js)
@vercel
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:20pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 9:20pm

@billyvg billyvg requested review from a team, bruno-garcia, jas-kas and lizokm October 17, 2024 17:23
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 21, 2024

Bundle Report

Changes will decrease total bundle size by 19 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.52MB 10 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 6 bytes (-0.0%) ⬇️

@billyvg billyvg merged commit 636c193 into master Oct 22, 2024
11 checks passed
@billyvg billyvg deleted the feat-replay-add-warning-angular-change-detection branch October 22, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants