feat(android): Add custom masking options for session replay #11624
+169
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 720 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
lizokm
approved these changes
Oct 22, 2024
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Made a few suggestions, but overall it looks good!
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
romtsn
commented
Oct 22, 2024
| ) | ||
| ``` | ||
|
|
||
| ## Masking Behavior |
Member
Author
There was a problem hiding this comment.
@lizokm thanks for reviewing it, I added one more section down below, could you take a look please?
|
|
||
| ## FAQ | ||
|
|
||
| Q: Why are parts of my replay not masked? |
Member
There was a problem hiding this comment.
Thank you for adding this. We should have this on iOS, React Native and Flutter too!
cc @brustolin @krystofwoldrich @vaind
lizokm
approved these changes
Oct 22, 2024
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Left a few more suggestions :)
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
romtsn
commented
Oct 23, 2024
romtsn
commented
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Privacypage that describes how to selectively mask/unmask vieews for replayPart of getsentry/sentry#74441
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.